Little improvement #184
Closed
Little improvement #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added full path to choco command in case when the system path is not updated yet. Adder foreach to Packages when use install or uninstall mode.
Added wait time to avoid rate limit in foreach
|
Can Choco be installed in different locations? I never like hard coding paths. Yes, there are times Choco fails because it needs an environment reload to get new path data after install and the windows path bugs don't help either. |
|
Thank you for this PR, it made us rework and improve the choco path to be not reliant on the choco env var that is part of the agent install. Script has been significantly reworked since then, so it's no longer in a mergable state. If you think the current script can still be improved, please update against current prod version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.