Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS Keys and Bucket Server-Side-Encryption #486

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

tobikris
Copy link
Contributor

@tobikris tobikris commented Jul 9, 2023

KMS Keys and Bucket Server-Side-Encryption

This PR implements the following changes:

  • add resource for KMS key
  • add resource for bucket server side encryption configuration

I am lacking a good idea on how to implement tests for those resources, as they require a working KMS. Should I add a KMS to the testing setup?

Reference

Closing issues

Copy link
Collaborator

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first contribution to this repository, @tobikris! 🎉
Thanks for implementing this!
There's just one change needed for the CI tests to pass, which I'm marking below.

minio/resource_minio_kms_key.go Outdated Show resolved Hide resolved
@felladrin
Copy link
Collaborator

I am lacking a good idea on how to implement tests for those resources, as they require a working KMS. Should I add a KMS to the testing setup?

You can open a discussion about it (as an issue). I'm not the best to comment on it, but other maintainers will probably share their thoughts :)

@felladrin felladrin merged commit 328699a into aminueza:master Jul 12, 2023
2 checks passed
@tobikris tobikris deleted the bucket-sse branch July 12, 2023 10:56
doonga referenced this pull request in doonga/greyrock-ops Jul 12, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://togithub.com/aminueza/terraform-provider-minio)) |
required_provider | minor | `1.15.2` -> `1.16.0` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v1.16.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.16.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.15.3...v1.16.0)

#### What's Changed

- KMS Keys and Bucket Server-Side-Encryption by
[@&#8203;tobikris](https://togithub.com/tobikris) in
[https://github.com/aminueza/terraform-provider-minio/pull/486](https://togithub.com/aminueza/terraform-provider-minio/pull/486)

#### New Contributors

- [@&#8203;tobikris](https://togithub.com/tobikris) made their first
contribution in
[https://github.com/aminueza/terraform-provider-minio/pull/486](https://togithub.com/aminueza/terraform-provider-minio/pull/486)

**Full Changelog**:
aminueza/terraform-provider-minio@v1.15.3...v1.16.0

###
[`v1.15.3`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.15.3)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.15.2...v1.15.3)

#### What's Changed

- Fix an example value of `expiration` by
[@&#8203;y-yagi](https://togithub.com/y-yagi) in
[https://github.com/aminueza/terraform-provider-minio/pull/462](https://togithub.com/aminueza/terraform-provider-minio/pull/462)
- Fix group status handling by
[@&#8203;asdevcapybara](https://togithub.com/asdevcapybara) in
[https://github.com/aminueza/terraform-provider-minio/pull/484](https://togithub.com/aminueza/terraform-provider-minio/pull/484)

#### New Contributors

- [@&#8203;y-yagi](https://togithub.com/y-yagi) made their first
contribution in
[https://github.com/aminueza/terraform-provider-minio/pull/462](https://togithub.com/aminueza/terraform-provider-minio/pull/462)
- [@&#8203;asdevcapybara](https://togithub.com/asdevcapybara) made their
first contribution in
[https://github.com/aminueza/terraform-provider-minio/pull/484](https://togithub.com/aminueza/terraform-provider-minio/pull/484)

**Full Changelog**:
aminueza/terraform-provider-minio@v1.15.2...v1.15.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43LjAiLCJ1cGRhdGVkSW5WZXIiOiIzNi43LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: KMS Keys and Bucket Server-Side-Encryption
2 participants