Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy object versions on bucket force_destroy #524

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Destroy object versions on bucket force_destroy #524

merged 1 commit into from
Oct 9, 2023

Conversation

pjsier
Copy link
Collaborator

@pjsier pjsier commented Oct 7, 2023 •
edited
Loading

Destroy object versions on force destroying bucket

Load all object versions when trying to clear out objects when force_destroy is set on a bucket. Previously this did not incorporate versions, so versioned objects would not all be deleted and cause destruction to fail.

Quick note that the test isn't great here, essentially just making sure we can delete a bucket with versioning and force_destroy, but I'm running into errors without logs when I include minio_s3_object resources and update them. Open to suggestions there, but wanted to add some testing to be safe.

Closing issues

@pjsier pjsier force-pushed the fix/509-destroy-versions branch 2 times, most recently from c4ead20 to c98d1b6 Compare October 7, 2023 01:18
@pjsier
Copy link
Collaborator Author

pjsier commented Oct 9, 2023

Quick update that @nixargh who originally reported #509 confirmed that this addresses the issue. This should be ready to go whenever anyone has a chance to review, thanks!

@felladrin
Copy link
Collaborator

Thanks, @pjsier! I'll release this fix as v1.18.2.

@felladrin felladrin merged commit a107f61 into aminueza:master Oct 9, 2023
2 checks passed
@pjsier pjsier deleted the fix/509-destroy-versions branch October 9, 2023 19:22
szinn referenced this pull request in szinn/k8s-homelab Oct 24, 2023
@repo-jeeves
feat(terraform): update terraform minio to 1.19.0 (#2577)
b9cc8d6 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://togithub.com/aminueza/terraform-provider-minio)) |
required_provider | minor | `1.18.0` -> `1.19.0` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v1.19.0`](https://togithub.com/terraform-provider-minio/terraform-provider-minio/releases/tag/v1.19.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.18.3...v1.19.0)

Changes on this Release:

- Update crazy-max/ghaction-import-gpg action to v6
([#&#8203;516](https://togithub.com/aminueza/terraform-provider-minio/issues/516))
- Handle empty service account policy
([#&#8203;518](https://togithub.com/aminueza/terraform-provider-minio/issues/518))
- Update repository URL
([#&#8203;520](https://togithub.com/aminueza/terraform-provider-minio/issues/520))
- Destroy object versions on bucket force_destroy
([#&#8203;524](https://togithub.com/aminueza/terraform-provider-minio/issues/524))
- Add Noncurrent Version expiration to ilm policy
([#&#8203;526](https://togithub.com/aminueza/terraform-provider-minio/issues/526))

**Full Changelog**:
aminueza/terraform-provider-minio@v1.18.0...v1.19.0

###
[`v1.18.3`](https://togithub.com/terraform-provider-minio/terraform-provider-minio/releases/tag/v1.18.3)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.18.0...v1.18.3)

Changes on this Release:

- Destroy object versions on bucket force_destroy
([https://github.com/terraform-provider-minio/terraform-provider-minio/pull/524](https://togithub.com/terraform-provider-minio/terraform-provider-minio/pull/524))
by [@&#8203;pjsier](https://togithub.com/pjsier)
- Handle empty service account policy
([https://github.com/terraform-provider-minio/terraform-provider-minio/pull/518](https://togithub.com/terraform-provider-minio/terraform-provider-minio/pull/518))
by [@&#8203;ArataEM](https://togithub.com/ArataEM)

**Full Changelog**:
aminueza/terraform-provider-minio@v1.18.0...v1.18.3

> **Note**
> This release replaces v1.18.1 and v1.18.2, which are unavailable on
https://registry.terraform.io/providers/aminueza/minio as they were
built with a GPG key that was only valid for the [previous
repository](https://togithub.com/aminueza/terraform-provider-minio/).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: repo-jeeves <106431701+repo-jeeves[bot]@users.noreply.github.com>
szinn referenced this pull request in szinn/k8s-homelab Nov 1, 2023
@repo-jeeves
feat(terraform): update terraform minio to 1.19.0 (#2617)
a43c829 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://togithub.com/aminueza/terraform-provider-minio)) |
required_provider | minor | `1.18.0` -> `1.19.0` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v1.19.0`](https://togithub.com/terraform-provider-minio/terraform-provider-minio/releases/tag/v1.19.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.18.3...v1.19.0)

Changes on this Release:

- Update crazy-max/ghaction-import-gpg action to v6
([#&#8203;516](https://togithub.com/aminueza/terraform-provider-minio/issues/516))
- Handle empty service account policy
([#&#8203;518](https://togithub.com/aminueza/terraform-provider-minio/issues/518))
- Update repository URL
([#&#8203;520](https://togithub.com/aminueza/terraform-provider-minio/issues/520))
- Destroy object versions on bucket force_destroy
([#&#8203;524](https://togithub.com/aminueza/terraform-provider-minio/issues/524))
- Add Noncurrent Version expiration to ilm policy
([#&#8203;526](https://togithub.com/aminueza/terraform-provider-minio/issues/526))

**Full Changelog**:
aminueza/terraform-provider-minio@v1.18.0...v1.19.0

###
[`v1.18.3`](https://togithub.com/terraform-provider-minio/terraform-provider-minio/releases/tag/v1.18.3)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.18.0...v1.18.3)

Changes on this Release:

- Destroy object versions on bucket force_destroy
([https://github.com/terraform-provider-minio/terraform-provider-minio/pull/524](https://togithub.com/terraform-provider-minio/terraform-provider-minio/pull/524))
by [@&#8203;pjsier](https://togithub.com/pjsier)
- Handle empty service account policy
([https://github.com/terraform-provider-minio/terraform-provider-minio/pull/518](https://togithub.com/terraform-provider-minio/terraform-provider-minio/pull/518))
by [@&#8203;ArataEM](https://togithub.com/ArataEM)

**Full Changelog**:
aminueza/terraform-provider-minio@v1.18.0...v1.18.3

> **Note**
> This release replaces v1.18.1 and v1.18.2, which are unavailable on
https://registry.terraform.io/providers/aminueza/minio as they were
built with a GPG key that was only valid for the [previous
repository](https://togithub.com/aminueza/terraform-provider-minio/).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNy4yIiwidXBkYXRlZEluVmVyIjoiMzcuMzcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: repo-jeeves <106431701+repo-jeeves[bot]@users.noreply.github.com>
felladrin pushed a commit that referenced this pull request Nov 4, 2023
@pjsier @felladrin
Destroy object versions on bucket force_destroy (#524)
4fdc7ea
felladrin pushed a commit that referenced this pull request Nov 4, 2023
@pjsier @felladrin
Destroy object versions on bucket force_destroy (#524)
9f77e2b 
(cherry picked from commit a107f61)
felladrin pushed a commit that referenced this pull request Nov 4, 2023
@pjsier @felladrin
Destroy object versions on bucket force_destroy (#524)
8cadc5b 
(cherry picked from commit a107f61)
felladrin added a commit that referenced this pull request Nov 4, 2023
@felladrin @renovate
@ArataEM @BuJo @pjsier @ndejesus @dependabot @tobikris
v1.20.0 release and setup of the v1 branch (#537)
78a04a9 
* Update module github.com/aws/aws-sdk-go to v1.45.6 (#515)

(cherry picked from commit 4953af3)

* Update crazy-max/ghaction-import-gpg action to v6 (#516)

(cherry picked from commit ee28b90)

* Handle empty service account policy (#518)

(cherry picked from commit 779d356)

* Update repository URL (#520)

(cherry picked from commit 7a680c7)

* Update project to Go v1.20 (#519)

(cherry picked from commit be07cf7)

* Destroy object versions on bucket force_destroy (#524)

(cherry picked from commit a107f61)

* Update goreleaser-action to v5 and add permission for the workflow to attach binaries to GitHub Releases (#521)

(cherry picked from commit c06ddba)

* Add Noncurrent Version expiration to ilm policy (#526)

Co-authored-by: Nicolas De Jesus <[email protected]>
(cherry picked from commit f031109)

* Bump golang.org/x/net from 0.15.0 to 0.17.0 (#530)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0.
- [Commits](golang/net@v0.15.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit ec7f197)

* Add service account values to read and import (#525)

(cherry picked from commit cf0c88d)

* Recreate user if it's not found anymore (#534)

Fixes #511

(cherry picked from commit 50bc121)

* Bump google.golang.org/grpc from 1.58.0 to 1.58.3 (#535)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.0 to 1.58.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.58.0...v1.58.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 5fa1a1b)

* Revert "Update repository URL (#520)" (#538)

This reverts commit 7a680c7.

(cherry picked from commit 8a0b114)

* Update target branches of GitHub Actions to `v1` branch

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Artem Usenko <[email protected]>
Co-authored-by: Jonathan Buch <[email protected]>
Co-authored-by: Pat Sier <[email protected]>
Co-authored-by: ndejesus <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tobias Krischer <[email protected]>
shosti pushed a commit to shosti/eevans-infra that referenced this pull request Dec 3, 2023
@shosti
Update Terraform minio to ~> 1.20.0 (#10)
fef67b3 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://github.com/aminueza/terraform-provider-minio)) | required_provider | minor | `~> 1.18.0` -> `~> 1.20.0` |

---

> ⚠ **Warning**
>
> Some dependencies could not be looked up. Check the warning logs for more information.

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

### [`v1.20.1`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.20.1)

[Compare Source](aminueza/terraform-provider-minio@v1.20.0...v1.20.1)

#### What's Changed

-   Fix null expiration date handling by [@&#8203;pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#545
-   Update terraform version to 1.5.7 in GitHub Action by [@&#8203;felladrin](https://github.com/felladrin) in aminueza/terraform-provider-minio#540

**Full Changelog**: aminueza/terraform-provider-minio@v1.20.0...v1.20.1

> **Note**
> [v1](https://github.com/aminueza/terraform-provider-minio/tree/v1) of the provider is now under maintenance mode. If you can, it's advised to upgrade to `v2`.

### [`v1.20.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.20.0)

[Compare Source](aminueza/terraform-provider-minio@v1.19.0...v1.20.0)

#### What's Changed

-   Update module github.com/aws/aws-sdk-go to v1.45.6 by [@&#8203;renovate](https://github.com/renovate) in aminueza/terraform-provider-minio#515
-   Update crazy-max/ghaction-import-gpg action to v6 by [@&#8203;renovate](https://github.com/renovate) in aminueza/terraform-provider-minio#516
-   Handle empty service account policy by [@&#8203;ArataEM](https://github.com/ArataEM) in aminueza/terraform-provider-minio#518
-   Go 1.20 by [@&#8203;BuJo](https://github.com/BuJo) in aminueza/terraform-provider-minio#519
-   Destroy object versions on bucket force_destroy by [@&#8203;pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#524
-   Update goreleaser-action to v5 and add permission for the workflow to attach binaries to GitHub Releases by [@&#8203;felladrin](https://github.com/felladrin) in aminueza/terraform-provider-minio#521
-   Add Noncurrent Version expiration to ilm policy by [@&#8203;ndejesus](https://github.com/ndejesus) in aminueza/terraform-provider-minio#526
-   Bump golang.org/x/net from 0.15.0 to 0.17.0 by [@&#8203;dependabot](https://github.com/dependabot) in aminueza/terraform-provider-minio#530
-   Add service account values to read and import by [@&#8203;pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#525
-   feat: recreate user if not found anymore by [@&#8203;tobikris](https://github.com/tobikris) in aminueza/terraform-provider-minio#534
-   Bump google.golang.org/grpc from 1.58.0 to 1.58.3 by [@&#8203;dependabot](https://github.com/dependabot) in aminueza/terraform-provider-minio#535

#### New Contributors

-   [@&#8203;ndejesus](https://github.com/ndejesus) made their first contribution in aminueza/terraform-provider-minio#526

**Full Changelog**: aminueza/terraform-provider-minio@v1.18.0...v1.20.0

> **Note**
> This release replaces v1.18.1 and v1.18.2, which are unavailable on https://registry.terraform.io/providers/aminueza/minio as they were built with an outdated GPG key. It also replaces v1.18.3 and v1.19.0, which couldn't be installed due the issue [#&#8203;531](aminueza/terraform-provider-minio#531).

### [`v1.19.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.19.0)

[Compare Source](aminueza/terraform-provider-minio@v1.18.3...v1.19.0)

Changes on this Release:

-   Update crazy-max/ghaction-import-gpg action to v6 ([#&#8203;516](aminueza/terraform-provider-minio#516))
-   Handle empty service account policy ([#&#8203;518](aminueza/terraform-provider-minio#518))
-   Update repository URL ([#&#8203;520](aminueza/terraform-provider-minio#520))
-   Destroy object versions on bucket force_destroy ([#&#8203;524](aminueza/terraform-provider-minio#524))
-   Add Noncurrent Version expiration to ilm policy ([#&#8203;526](aminueza/terraform-provider-minio#526))

**Full Changelog**: aminueza/terraform-provider-minio@v1.18.0...v1.19.0

> **Note**
> This release replaces v1.18.1 and v1.18.2, which are unavailable on https://registry.terraform.io/providers/aminueza/minio as they were built with an outdated GPG key. It also replaces v1.18.3, which couldn't be installed due the issue [#&#8203;531](aminueza/terraform-provider-minio#531).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4wIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://gitea.eevans.me/shosti/eevans-infra/pulls/10
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
kireque referenced this pull request in kireque/home-ops Feb 7, 2024
@kireque-bot
feat(terraform-provider): update terraform minio to 1.20.1 (#338)
9b9924e 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://togithub.com/aminueza/terraform-provider-minio)) |
required_provider | minor | `1.19.0` -> `1.20.1` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v1.20.1`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.20.1)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.20.0...v1.20.1)

#### What's Changed

- Fix null expiration date handling by
[@&#8203;pjsier](https://togithub.com/pjsier) in
[https://github.com/aminueza/terraform-provider-minio/pull/545](https://togithub.com/aminueza/terraform-provider-minio/pull/545)
- Update terraform version to 1.5.7 in GitHub Action by
[@&#8203;felladrin](https://togithub.com/felladrin) in
[https://github.com/aminueza/terraform-provider-minio/pull/540](https://togithub.com/aminueza/terraform-provider-minio/pull/540)

**Full Changelog**:
aminueza/terraform-provider-minio@v1.20.0...v1.20.1

> **Note**
> [v1](https://togithub.com/aminueza/terraform-provider-minio/tree/v1)
of the provider is now under maintenance mode. If you can, it's advised
to upgrade to `v2`.

###
[`v1.20.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.20.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.19.0...v1.20.0)

#### What's Changed

- Update module github.com/aws/aws-sdk-go to v1.45.6 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/aminueza/terraform-provider-minio/pull/515](https://togithub.com/aminueza/terraform-provider-minio/pull/515)
- Update crazy-max/ghaction-import-gpg action to v6 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/aminueza/terraform-provider-minio/pull/516](https://togithub.com/aminueza/terraform-provider-minio/pull/516)
- Handle empty service account policy by
[@&#8203;ArataEM](https://togithub.com/ArataEM) in
[https://github.com/aminueza/terraform-provider-minio/pull/518](https://togithub.com/aminueza/terraform-provider-minio/pull/518)
- Go 1.20 by [@&#8203;BuJo](https://togithub.com/BuJo) in
[https://github.com/aminueza/terraform-provider-minio/pull/519](https://togithub.com/aminueza/terraform-provider-minio/pull/519)
- Destroy object versions on bucket force_destroy by
[@&#8203;pjsier](https://togithub.com/pjsier) in
[https://github.com/aminueza/terraform-provider-minio/pull/524](https://togithub.com/aminueza/terraform-provider-minio/pull/524)
- Update goreleaser-action to v5 and add permission for the workflow to
attach binaries to GitHub Releases by
[@&#8203;felladrin](https://togithub.com/felladrin) in
[https://github.com/aminueza/terraform-provider-minio/pull/521](https://togithub.com/aminueza/terraform-provider-minio/pull/521)
- Add Noncurrent Version expiration to ilm policy by
[@&#8203;ndejesus](https://togithub.com/ndejesus) in
[https://github.com/aminueza/terraform-provider-minio/pull/526](https://togithub.com/aminueza/terraform-provider-minio/pull/526)
- Bump golang.org/x/net from 0.15.0 to 0.17.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/aminueza/terraform-provider-minio/pull/530](https://togithub.com/aminueza/terraform-provider-minio/pull/530)
- Add service account values to read and import by
[@&#8203;pjsier](https://togithub.com/pjsier) in
[https://github.com/aminueza/terraform-provider-minio/pull/525](https://togithub.com/aminueza/terraform-provider-minio/pull/525)
- feat: recreate user if not found anymore by
[@&#8203;tobikris](https://togithub.com/tobikris) in
[https://github.com/aminueza/terraform-provider-minio/pull/534](https://togithub.com/aminueza/terraform-provider-minio/pull/534)
- Bump google.golang.org/grpc from 1.58.0 to 1.58.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/aminueza/terraform-provider-minio/pull/535](https://togithub.com/aminueza/terraform-provider-minio/pull/535)

#### New Contributors

- [@&#8203;ndejesus](https://togithub.com/ndejesus) made their first
contribution in
[https://github.com/aminueza/terraform-provider-minio/pull/526](https://togithub.com/aminueza/terraform-provider-minio/pull/526)

**Full Changelog**:
aminueza/terraform-provider-minio@v1.18.0...v1.20.0

> **Note**
> This release replaces v1.18.1 and v1.18.2, which are unavailable on
https://registry.terraform.io/providers/aminueza/minio as they were
built with an outdated GPG key. It also replaces v1.18.3 and v1.19.0,
which couldn't be installed due the issue
[#&#8203;531](https://togithub.com/aminueza/terraform-provider-minio/issues/531).

###
[`v1.19.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.19.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.18.3...v1.19.0)

Changes on this Release:

- Update crazy-max/ghaction-import-gpg action to v6
([#&#8203;516](https://togithub.com/aminueza/terraform-provider-minio/issues/516))
- Handle empty service account policy
([#&#8203;518](https://togithub.com/aminueza/terraform-provider-minio/issues/518))
- Update repository URL
([#&#8203;520](https://togithub.com/aminueza/terraform-provider-minio/issues/520))
- Destroy object versions on bucket force_destroy
([#&#8203;524](https://togithub.com/aminueza/terraform-provider-minio/issues/524))
- Add Noncurrent Version expiration to ilm policy
([#&#8203;526](https://togithub.com/aminueza/terraform-provider-minio/issues/526))

**Full Changelog**:
aminueza/terraform-provider-minio@v1.18.0...v1.19.0

> **Note**
> This release replaces v1.18.1 and v1.18.2, which are unavailable on
https://registry.terraform.io/providers/aminueza/minio as they were
built with an outdated GPG key. It also replaces v1.18.3, which couldn't
be installed due the issue
[#&#8203;531](https://togithub.com/aminueza/terraform-provider-minio/issues/531).

###
[`v1.18.3`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.18.3)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.18.0...v1.18.3)

Changes on this Release:

- Destroy object versions on bucket force_destroy
([https://github.com/terraform-provider-minio/terraform-provider-minio/pull/524](https://togithub.com/terraform-provider-minio/terraform-provider-minio/pull/524))
by [@&#8203;pjsier](https://togithub.com/pjsier)
- Handle empty service account policy
([https://github.com/terraform-provider-minio/terraform-provider-minio/pull/518](https://togithub.com/terraform-provider-minio/terraform-provider-minio/pull/518))
by [@&#8203;ArataEM](https://togithub.com/ArataEM)

**Full Changelog**:
aminueza/terraform-provider-minio@v1.18.0...v1.18.3

> **Note**
> This release replaces v1.18.1 and v1.18.2, which are unavailable on
https://registry.terraform.io/providers/aminueza/minio as they were
built with an outdated GPG key.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzQuMyIsInVwZGF0ZWRJblZlciI6IjM3LjE3NC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
kireque referenced this pull request in kireque/home-ops Mar 12, 2024
@kireque-bot
feat(terraform-provider)!: Update Terraform minio to 2.1.0 (#386)
4831cde 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://togithub.com/aminueza/terraform-provider-minio)) |
required_provider | major | `1.20.1` -> `2.1.0` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v2.1.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.1.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.0.1...v2.1.0)

#### What's Changed

- Fixed group policy assign parameter typo by
[@&#8203;danielhass](https://togithub.com/danielhass) in
[https://github.com/aminueza/terraform-provider-minio/pull/553](https://togithub.com/aminueza/terraform-provider-minio/pull/553)
- Document `DeleteMarker` expiry in ilm policy by
[@&#8203;michaelruigrok](https://togithub.com/michaelruigrok) in
[https://github.com/aminueza/terraform-provider-minio/pull/558](https://togithub.com/aminueza/terraform-provider-minio/pull/558)
- Add resource_minio_s3\_object 'source' support by
[@&#8203;fhemberger](https://togithub.com/fhemberger) in
[https://github.com/aminueza/terraform-provider-minio/pull/555](https://togithub.com/aminueza/terraform-provider-minio/pull/555)

#### New Contributors

- [@&#8203;danielhass](https://togithub.com/danielhass) made their first
contribution in
[https://github.com/aminueza/terraform-provider-minio/pull/553](https://togithub.com/aminueza/terraform-provider-minio/pull/553)
- [@&#8203;michaelruigrok](https://togithub.com/michaelruigrok) made
their first contribution in
[https://github.com/aminueza/terraform-provider-minio/pull/558](https://togithub.com/aminueza/terraform-provider-minio/pull/558)
- [@&#8203;fhemberger](https://togithub.com/fhemberger) made their first
contribution in
[https://github.com/aminueza/terraform-provider-minio/pull/555](https://togithub.com/aminueza/terraform-provider-minio/pull/555)

**Full Changelog**:
aminueza/terraform-provider-minio@v2.0.1...v2.1.0

###
[`v2.0.1`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.0.1)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.0.0...v2.0.1)

#### What's Changed

- Fix null expiration date handling by
[@&#8203;pjsier](https://togithub.com/pjsier) in
[https://github.com/aminueza/terraform-provider-minio/pull/545](https://togithub.com/aminueza/terraform-provider-minio/pull/545)
- Update terraform version to 1.5.7 in GitHub Action by
[@&#8203;felladrin](https://togithub.com/felladrin) in
[https://github.com/aminueza/terraform-provider-minio/pull/540](https://togithub.com/aminueza/terraform-provider-minio/pull/540)

**Full Changelog**:
aminueza/terraform-provider-minio@v2.0.0...v2.0.1

###
[`v2.0.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.0.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.20.1...v2.0.0)

#### What's Changed

- Update madmin-go to version 3 by
[@&#8203;acolombier](https://togithub.com/acolombier) in
[https://github.com/aminueza/terraform-provider-minio/pull/514](https://togithub.com/aminueza/terraform-provider-minio/pull/514)
- Handle empty service account policy by
[@&#8203;ArataEM](https://togithub.com/ArataEM) in
[https://github.com/aminueza/terraform-provider-minio/pull/518](https://togithub.com/aminueza/terraform-provider-minio/pull/518)
- Go 1.20 by [@&#8203;BuJo](https://togithub.com/BuJo) in
[https://github.com/aminueza/terraform-provider-minio/pull/519](https://togithub.com/aminueza/terraform-provider-minio/pull/519)
- Destroy object versions on bucket force_destroy by
[@&#8203;pjsier](https://togithub.com/pjsier) in
[https://github.com/aminueza/terraform-provider-minio/pull/524](https://togithub.com/aminueza/terraform-provider-minio/pull/524)
- Update goreleaser-action to v5 and add permission for the workflow to
attach binaries to GitHub Releases by
[@&#8203;felladrin](https://togithub.com/felladrin) in
[https://github.com/aminueza/terraform-provider-minio/pull/521](https://togithub.com/aminueza/terraform-provider-minio/pull/521)
- Add Noncurrent Version expiration to ilm policy by
[@&#8203;ndejesus](https://togithub.com/ndejesus) in
[https://github.com/aminueza/terraform-provider-minio/pull/526](https://togithub.com/aminueza/terraform-provider-minio/pull/526)
- Add service account values to read and import by
[@&#8203;pjsier](https://togithub.com/pjsier) in
[https://github.com/aminueza/terraform-provider-minio/pull/525](https://togithub.com/aminueza/terraform-provider-minio/pull/525)
- feat: add minio_s3\_bucket_replication resource by
[@&#8203;acolombier](https://togithub.com/acolombier) in
[https://github.com/aminueza/terraform-provider-minio/pull/528](https://togithub.com/aminueza/terraform-provider-minio/pull/528)
- feat: recreate user if not found anymore by
[@&#8203;tobikris](https://togithub.com/tobikris) in
[https://github.com/aminueza/terraform-provider-minio/pull/534](https://togithub.com/aminueza/terraform-provider-minio/pull/534)
- Bump google.golang.org/grpc from 1.58.0 to 1.58.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/aminueza/terraform-provider-minio/pull/535](https://togithub.com/aminueza/terraform-provider-minio/pull/535)
- Change terraform-provider-minio license to AGPL-3.0 and append `/v2`
to the module name by [@&#8203;BuJo](https://togithub.com/BuJo) in
[https://github.com/aminueza/terraform-provider-minio/pull/522](https://togithub.com/aminueza/terraform-provider-minio/pull/522)

#### Breaking Change: About the major version update

We've updated `madmin-go` to `v3` so we can use the new features from
the SDK, like the [bucket
replication](https://togithub.com/aminueza/terraform-provider-minio/pull/528).
As a consequence of this, we had to change our License to AGPL-3.0 to
comply with `madmin-go`, [which has been using AGPL-3.0 since its v2
release](https://togithub.com/minio/madmin-go/pull/154).

For those who can't upgrade to **terraform-provider-minio v2** due to
license incompatibilities, we recommend you keep using the **v1** until
you feel you need some of the new features.

To don't let anyone behind, we've created a
[v1](https://togithub.com/aminueza/terraform-provider-minio/tree/v1)
branch, which is now protected and will live along with the
[main](https://togithub.com/aminueza/terraform-provider-minio/tree/main).
So if users of `v1` want to push features/fixes, they can create pull
requests targeting that branch, and as soon as it's merged, we release a
new update for the `v1.x`.

For those importing this package in their software and want to upgrade,
here's the command to upgrade:

```bash
go get github.com/aminueza/terraform-provider-minio/v2@&#8203;v2.0.0
```

**Full Changelog**:
aminueza/terraform-provider-minio@v1.18.0...v2.0.0

> **Note**
> [v1](https://togithub.com/aminueza/terraform-provider-minio/tree/v1)
branch diverged from
[main](https://togithub.com/aminueza/terraform-provider-minio/tree/main)
at after the [release
v1.18.0](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.18.0).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzUuNSIsInVwZGF0ZWRJblZlciI6IjM3LjIzNS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felladrin felladrin felladrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'minio_s3_bucket' with versioning can't be destroyed
2 participants
@pjsier @felladrin