-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle case when IAM Policy was deleted externally #569
Merged
felladrin
merged 3 commits into
aminueza:main
from
s-vitaliy:fix/handle_iam_policy_delete_external
Jun 20, 2024
Merged
fix: Handle case when IAM Policy was deleted externally #569
felladrin
merged 3 commits into
aminueza:main
from
s-vitaliy:fix/handle_iam_policy_delete_external
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix and congrats on your first contribution to this repo, @s-vitaliy! 🎉
kireque
referenced
this pull request
in kireque/home-ops
Jun 21, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://togithub.com/aminueza/terraform-provider-minio)) | required_provider | patch | `2.3.1` -> `2.3.2` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v2.3.2`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.3.2) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.3.1...v2.3.2) #### What's Changed - Fix: Handle case when IAM Policy was deleted externally by [@​s-vitaliy](https://togithub.com/s-vitaliy) in [https://github.com/aminueza/terraform-provider-minio/pull/569](https://togithub.com/aminueza/terraform-provider-minio/pull/569) #### New Contributors - [@​s-vitaliy](https://togithub.com/s-vitaliy) made their first contribution in [https://github.com/aminueza/terraform-provider-minio/pull/569](https://togithub.com/aminueza/terraform-provider-minio/pull/569) **Full Changelog**: aminueza/terraform-provider-minio@v2.3.1...v2.3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMyIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
szinn
referenced
this pull request
in szinn/k8s-homelab
Jun 22, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://togithub.com/aminueza/terraform-provider-minio)) | required_provider | patch | `2.3.0` -> `2.3.2` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v2.3.2`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.3.2) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.3.1...v2.3.2) #### What's Changed - Fix: Handle case when IAM Policy was deleted externally by [@​s-vitaliy](https://togithub.com/s-vitaliy) in [https://github.com/aminueza/terraform-provider-minio/pull/569](https://togithub.com/aminueza/terraform-provider-minio/pull/569) #### New Contributors - [@​s-vitaliy](https://togithub.com/s-vitaliy) made their first contribution in [https://github.com/aminueza/terraform-provider-minio/pull/569](https://togithub.com/aminueza/terraform-provider-minio/pull/569) **Full Changelog**: aminueza/terraform-provider-minio@v2.3.1...v2.3.2 ### [`v2.3.1`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.3.1) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.3.0...v2.3.1) #### What's Changed - Fix Azure and GCP remote tier creation and add support for tier options by [@​s2thudry](https://togithub.com/s2thudry) in [https://github.com/aminueza/terraform-provider-minio/pull/566](https://togithub.com/aminueza/terraform-provider-minio/pull/566) - Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/aminueza/terraform-provider-minio/pull/567](https://togithub.com/aminueza/terraform-provider-minio/pull/567) - Bump golang.org/x/net from 0.17.0 to 0.23.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/aminueza/terraform-provider-minio/pull/568](https://togithub.com/aminueza/terraform-provider-minio/pull/568) **Full Changelog**: aminueza/terraform-provider-minio@v2.3.0...v2.3.1 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL3BhdGNoIl19--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle case when an IAM policy was Removed externally
Currently the provider has very annoying bug: if an IAM policy was removed externally, plan fails and the project that contains minio policies becomes unplannable.
This PR implements the following changes:
XMinioAdminNoSuchPolicy
error code, similar to how it is handled in the minio_iam_user resource.The new behavior:
Reference
Resolves #550
Closing issues