feat(IBotRequest location): add location title that we receive from f…

…acebook to ILocation
amitevski · Jun 20, 2016 · 2b3bc5e · 2b3bc5e
1 parent 414ae02
commit 2b3bc5e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/facebook/bot.ts b/src/facebook/bot.ts
@@ -140,9 +140,12 @@ export class FacebookBot {
           this.botController.imageMessage(imageMessage, reply) || null;
           break;
         case FB_ATTACHMENT_TYPE.LOCATION:
-          let location = {
+          let location: IBotRequest = {
             user, location: {coordinates: attachment.payload.coordinates}, type: BOT_REQUEST_TYPE.FACEBOOK
           };
+          if (attachment.title) {
+            location.location.title = attachment.title;
+          }
           (this.botController.locationMessage) ? this.botController.locationMessage(location, reply) : null;
           break;
         case FB_ATTACHMENT_TYPE.FALLBACK:

diff --git a/src/interfaces.ts b/src/interfaces.ts
@@ -26,6 +26,7 @@ export interface ICoordinates {
   long: number;
 }
 export interface ILocation {
+  title?: string;
   coordinates: ICoordinates;
 }
 

diff --git a/tests/bot.spec.ts b/tests/bot.spec.ts
@@ -12,6 +12,7 @@ class DummyController implements IBotController {
     imageMessage: 0,
     linkMessage: 0,
     locationMessage: 0,
+    location: {},
     delivered: 0,
     catchAll: 0,
   }
@@ -20,7 +21,7 @@ class DummyController implements IBotController {
   textMessage(msg: IBotRequest, reply: IBotReply) {console.log('got new textMessage'); this.cc.textMessage++;}
   imageMessage(image: IBotRequest, reply: IBotReply) {console.log('got new imageMessage'); this.cc.imageMessage++;}
   linkMessage(msg: IBotRequest, reply: IBotReply) {console.log('got linkMessage'); this.cc.linkMessage++;}
-  locationMessage(msg: IBotRequest, reply: IBotReply) {console.log('got locationMessage'); this.cc.locationMessage++;}
+  locationMessage(msg: IBotRequest, reply: IBotReply) {console.log('got locationMessage'); this.cc.locationMessage++; this.cc.location = msg.location;}
   delivered(msg: IBotRequest, reply: IBotReply) {console.log('got delivered'); this.cc.delivered++;}
   catchAll(msg: IBotRequest, reply: IBotReply) {console.log('got catchAll'); this.cc.catchAll++;}
 }
@@ -63,10 +64,19 @@ describe('FacebookBot', () => {
             expect(ctrl.cc.imageMessage).to.eql(1);
             expect(ctrl.cc.locationMessage).to.eql(1);
             done();
-          })
+          });
+
           // just console.log testing for now :(
           // if anyone knows a good mocking library for typescript youre welcome :)
         });
+
+        it('should get location title', (done) => {
+            bot.receiveMessage(fakeMessageMixed())
+            .then( dispatchResults => {
+              expect(ctrl.cc.location['title']).to.eql(`Aco's Location`);
+              done();
+            });
+        });
 
     });
    describe('dispatchSingleMessage', () => {