Skip to content

Commit

Permalink
Match poisson_cdf function signature with Presto. (facebookincubator#…
Browse files Browse the repository at this point in the history
…10555)

Summary: Pull Request resolved: facebookincubator#10555

Differential Revision: D60195184
  • Loading branch information
amitkdutta authored and facebook-github-bot committed Jul 24, 2024
1 parent ba35860 commit 2de6a5a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ void registerProbTrigFunctions(const std::string& prefix) {
{prefix + "inverse_beta_cdf"});
registerFunction<InverseNormalCDFFunction, double, double, double, double>(
{prefix + "inverse_normal_cdf"});
registerFunction<PoissonCDFFunction, double, double, int64_t>(
{prefix + "poisson_cdf"});
registerFunction<PoissonCDFFunction, double, double, int32_t>(
{prefix + "poisson_cdf"});
registerFunction<GammaCDFFunction, double, double, double, double>(
Expand Down
1 change: 0 additions & 1 deletion velox/functions/prestosql/tests/ProbabilityTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,6 @@ TEST_F(ProbabilityTest, gammaCDF) {

TEST_F(ProbabilityTest, poissonCDF) {
poissonCDFTests<int32_t>();
poissonCDFTests<int64_t>();
}

TEST_F(ProbabilityTest, binomialCDF) {
Expand Down

0 comments on commit 2de6a5a

Please sign in to comment.