forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix the HashTable::storeRowPointer to accept int64 bucketoffset (face…
…bookincubator#7308) Summary: The bucket offsets in a HashTable could cross INT32_MAX. This leads to incorrect address calculation in `HashTable::storeRowPoint` while storing a row pointer in the table. We can reproduce this on a TPC-DS 1K dataset. Incorrect results: ``` select count(ws_order_number) as "order count" from web_sales where ws_order_number in (select ws_order_number from web_sales); order count ------------- 289805994 (1 row) ``` Correct results: ``` presto:tpcds_sf_1000> select count(ws_order_number) from web_sales_on where ws_order_number in (select ws_order_number from web_sales_on); _col0 ----------- 720000376 (1 row) ``` Resolves prestodb/presto#20972 Pull Request resolved: facebookincubator#7308 Reviewed By: Yuhta Differential Revision: D50988774 Pulled By: xiaoxmeng fbshipit-source-id: 5233deec0dc803e80509cce7541053e501f8e859
- Loading branch information
1 parent
cc52535
commit 7ea06dc
Showing
3 changed files
with
45 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters