Skip to content

Commit

Permalink
Set hash_probe_finish_early_on_empty_build to false by default. (face…
Browse files Browse the repository at this point in the history
…bookincubator#10735)

Summary:
Pull Request resolved: facebookincubator#10735

Keeping `hash_probe_finish_early_on_empty_build` to true causes queries to fail with `split source is closed` error. This is very hard to debug and in all deployment setup we set it to `false`. Making the default behavior to `false` to avoid confusing query errors for users.

Reviewed By: xiaoxmeng

Differential Revision: D61193165
  • Loading branch information
amitkdutta authored and facebook-github-bot committed Aug 13, 2024
1 parent 13899de commit 932644c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion velox/core/QueryConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ class QueryConfig {
}

bool hashProbeFinishEarlyOnEmptyBuild() const {
return get<bool>(kHashProbeFinishEarlyOnEmptyBuild, true);
return get<bool>(kHashProbeFinishEarlyOnEmptyBuild, false);
}

uint32_t minTableRowsForParallelJoinBuild() const {
Expand Down

0 comments on commit 932644c

Please sign in to comment.