ci: pin runner image versions #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key change here is using macos-12 instead of macos-latest. This prevents the runner from switching to arm64, for which there are no compiled versions of older Python targets (i.e. 3.8, 3.9).
|
but why also change ubuntu and windows? Going away from "latest" is only a workaround. |
in general version pinning so breaking changes are not administered automatically is a good way to run things. i will figure out a matrix that tests both, but in the meantime this is fine. welcome back, by the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
The key change here is using macos-12 instead of macos-latest. This
prevents the runner from switching to arm64, for which there are no
compiled versions of older Python targets (i.e. 3.8, 3.9).