Handle database namespaces for cached tables #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t reflected on the shark UI
Cached tables currently ignore database name which makes caching buggy for users using multiple databases. Enhanced the memoryMetadataManager to require database name inaddition to the tablename for all metadata operations.
|
Can one of the admins verify this patch? |
|
Thanks, Sundeep. This part of the codebase is undergoing pretty big changes by Harvey right now. I will ask Harvey to merge your changes into Shark as part of his partition cached table change. |
|
Jenkins, add to whitelist. |
|
Build triggered. |
|
Build started. |
|
Build finished. |
|
One or more automated tests failed |
|
All this functionality is now in the master. Closing this request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cached tables currently ignore database name which makes caching buggy for users using multiple databases.
Enhanced the memoryMetadataManager to require database name inaddition to the tablename for all metadata operations.