Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding slots for empty filter results and empty dataset provided #107

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Adding slots for empty filter results and empty dataset provided #107

wants to merge 18 commits into from

Commits on Jan 8, 2019

  1. filter node with id 

    node's text & id are flat and we can search node's id as regex too
    @ghanbari
    ghanbari authored Jan 8, 2019
    Configuration menu
    Copy the full SHA
    9c65974 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. style for RTL direction

    @ghanbari
    ghanbari authored Jan 11, 2019
    Configuration menu
    Copy the full SHA
    9d02167 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Merge pull request amsik#96 from ghanbari/patch-1 

    style for RTL direction
    @amsik
    amsik authored Jan 14, 2019
    Configuration menu
    Copy the full SHA
    235f6f0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request amsik#94 from ghanbari/patch-2 

    filter node with id
    @amsik
    amsik authored Jan 14, 2019
    Configuration menu
    Copy the full SHA
    c08d540 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Add draggable class to TreeNode

    Tristan Fontaine committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    ae709f9 View commit details
    Browse the repository at this point in the history

  2. Modify emptyText output 

    Switching from mustache to v-html option allows to output both text and HTML message on filter "nothing found"
    @moroq
    moroq authored Jan 29, 2019
    Configuration menu
    Copy the full SHA
    6a33877 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Merge pull request amsik#103 from moroq/patch-1 

    Modify emptyText output
    @amsik
    amsik authored Jan 30, 2019
    Configuration menu
    Copy the full SHA
    941e278 View commit details
    Browse the repository at this point in the history

  2. Merge pull request amsik#102 from N00ts/master 

    Add draggable class to TreeNode
    @amsik
    amsik authored Jan 30, 2019
    Configuration menu
    Copy the full SHA
    43a9b1e View commit details
    Browse the repository at this point in the history

  3. Adding slotted messages in TreeRoot.vue 

    Rethinking my previous PR: it is better to have wonderful component slot to display message on empty filtering result. We can get rid of emptyText prop and custom div with custom class.
And along with this: it is good to have slot for empty dataset message. Because when we fetch data from external source - we never know if there is actually any structure. So I added another slot on matches.length == 0
    @moroq
    moroq authored Jan 30, 2019
    Configuration menu
    Copy the full SHA
    a1b6ad0 View commit details
    Browse the repository at this point in the history

  4. Merge pull request amsik#104 from moroq/patch-1 

    Adding slotted messages in TreeRoot.vue
    @amsik
    amsik authored Jan 30, 2019
    Configuration menu
    Copy the full SHA
    a9fe175 View commit details
    Browse the repository at this point in the history

  5. Revert "Adding slotted messages in TreeRoot.vue"

    @moroq
    moroq authored Jan 30, 2019
    Configuration menu
    Copy the full SHA
    186fff0 View commit details
    Browse the repository at this point in the history

  6. Merge pull request amsik#105 from moroq/revert-104-patch-1 

    Revert "Adding slotted messages in TreeRoot.vue"
    @amsik
    amsik authored Jan 30, 2019
    Configuration menu
    Copy the full SHA
    1cd3cf8 View commit details
    Browse the repository at this point in the history

  7. Added class for empty-filter-text

    @amsik
    amsik committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    ec90c4f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of https://github.com/amsik/liquor-tree

    @amsik
    amsik committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    d28df9b View commit details
    Browse the repository at this point in the history

  9. Fix message

    @amsik
    amsik committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    4a35b4c View commit details
    Browse the repository at this point in the history

  10. Update version

    @amsik
    amsik committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    e2da9ee View commit details
    Browse the repository at this point in the history

  11. FIx filtering default matcher

    @amsik
    amsik committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    3629821 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Adding slots for empty filter results and empty dataset provided. Tes… 

    …ted.
    @moroq
    moroq committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    a9e999d View commit details
    Browse the repository at this point in the history