fix: Change databuilder search data extractors to publish name in user document.

[glipR]

Description

Changes the search data databuilder extractors to extract a name field, for publishing to elasticsearch.

Currently, the user document schema in elasticsearch expects a name keyword, which is the primary field for searching users. (Expected from Databuilder publish, and expected from search service)

Motivation and Context

The change is required because currently the elasticsearch query does not use the name field to create better matches for search results, and instead is likely just using first/last and key of the user. This is fine when searching for just first or last, but when searching both the search results currently aren't great for this reason.

This is actually fixed in the example query (PR) for posting from neo4j to elasticsearch, but this query is never used.

How Has This Been Tested?

This has only been tested with the neo4j_search_data_extractor, and not the other extractors. Testing was done by:

1. Loading from databuilder via the search_data_extractor script
2. Navigating to the index on localhost:9200 and inspecting document values
3. Attempting a search in the frontend and comparing results

Documentation

No change in documentation

CheckList

• PR title addresses the issue accurately and concisely

Believe this fix has no need for:

• N/A: Updates Documentation and Docstrings
• N/A: Adds tests
• N/A: Adds instrumentation (logs, or UI events)

[boring-cyborg]

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

[kristenarmes]

@glipR thanks for your contribution! I triggered the CI tests and see a couple minor test failures. if you can resolve, I'd be happy to approve

[glipR]

Thanks @kristenarmes ! I've edited the two failing tests to reflect the new return values / expected arguments.

Apologies I'm having trouble triggering the tests locally due to some version conflicts so may need a retrigger to confirm that that has fixed everything 🙏

[glipR]

Didn't notice they'd been rerun, apologies for the delay :)

Looks like everything is passing now, thanks again for triggering these.

[kristenarmes]

LGTM, thanks!

[kristenarmes]

I was about to merge, but realized did you want to bump the databuilder version? here's the version spot

[glipR]

Sure thing - have bumped the patch version.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!