Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactored bitmap typings #72

Merged
merged 1 commit into from
Dec 2, 2019
Merged

chore: refactored bitmap typings #72

merged 1 commit into from
Dec 2, 2019

Conversation

L2jLiga
Copy link
Contributor

@L2jLiga L2jLiga commented Nov 20, 2019

Issue: #70

Description of changes:
Refactored Bitmap type definitions to be consistent with other definitions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -4,7 +4,6 @@ import RulerData from '../RulerData';

declare class Artboard extends Group {
_class: 'artboard';
shouldBreakMaskChain: boolean;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inherited from Layer same for other similar changes

Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

(apologies, I have been away for the last 2 weeks for the birth of my first child)

@dbanksdesign dbanksdesign merged commit a294ac6 into amzn:master Dec 2, 2019
@dbanksdesign
Copy link
Member

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@L2jLiga L2jLiga deleted the chore/bitmap-typings branch December 3, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants