added timeout property and implemented the property in both OkHttpNetworkHandler and NSUrlSessionHandler #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workHandler and NSUrlSessionHandler
Create CODE_OF_CONDUCT.md
|
Maybe this can solve the issue i have where timeout is not respected in Android. |
|
@alexrainman It's been a while, but I'm curious, did this solve your timeout issues with Android? |
|
This dosen't seem to work for me on android. Timeout is alwaysl null inside of SendAsync causing it to be ignored. |
|
Yes, it is solved and included in my branch modernhttpclient-updated |
The setting of: rq.TimeoutInterval = Timeout.Value.Seconds; Should be: rq.TimeoutInterval = Timeout.Value.TotalSeconds; so that the TimeoutInterval is set to the TimeSpan in seconds rather than the seconds part of the Timespan which would be zero for any whole minute.
NSUrlSessionHandler: TimeoutInterval to TotalSeconds rather than Seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into issues with our implementation of ModernHttpClient not properly obeying our set timeout interval in iOS. Since we don't have access to the client directly here the best option seemed to be to add a new property and passing that down into the respective request handlers for each platform.