Support netstandard #248
Support netstandard #248
Conversation
|
Can somebody merge this PR? It would solve most problems when trying to use other netstandard libraries... |
|
Just curious, would the netstandard support changes be expected to cause problems when using this in profile-based PCLs? |
|
If using NET Standard 1.2 and above, yes it would be impossible to consume in a PCL. |
|
Thanks for the answer. I've been using Xamarin.Forms and profile based PCLs, so that might prevent myself and others from being able to use the updated version. I believe something similar happened when sqlite-net-pcl added NET Standard support. (In that case had to revert back to version 1.2.1.) Just something to consider. I don't know if there's a workaround. |
|
@WillsB Are you thinking to publish the package into NuGet? When can we use this library with NET standard support? |
|
Yep - I'm waiting for this too. (+1)
…On Thu, Aug 3, 2017 at 4:47 AM, nazgul87 ***@***.***> wrote:
@WillsB <https://github.com/willsb> Are you thinking to publish the
package into NuGet? When can we use this library with NET standard support?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMdOEqme5XAIfjh-hZHXJ2eqwPjOmt7aks5sUULKgaJpZM4NS17G>
.
|
|
You can use a netstandard binary in a PCL project. |
|
With most libraries currently converting to .net standard it would be greatly appreciated if this one follows. |
|
@Pinox it probably wont. Use the built in HttpClientHandlers Xamarin provides instead. Last commit on this lib was more than 2 years ago. |
|
@Cheesebaron i have an updated version of this library. Find it as modernhttpclient-updated. I will release one that supports netstandard. Not sure yet which version is best, 2.0? |
|
Thanks @Cheesebaron @alexrainman . I mainly use the current ModernHttpClient with Servicestack as it is a recommended lib with their JsonHttpClient on mobile. Servicestack upgraded to .net standard 2 in December, so I am in the process of upgrading my projects. Alex will wait then for your updated lib, you probably want to go for the lowest .net standard version for maximum compat in different projects , but if the target market is Windows 10 and Xamarin then .net standard 2 will do as most users are on Fall Creative Update anyway and latest Xamarin Forms support .net standard 2. |
|
@Pinox the plugin doesn’t have a UWP version but i always prefer to target latest version anyway. Usually y provide both netstandard and PCL. |
|
@alexrainman , awesome news. Win10 reference in context to my current code base that cross desktop and mobile. Once .net standard version released I will post a message on servicestack forum about the updated lib for others to use. |
|
@Pinox my version provides a fix for timeout in Android, updates to OkHttp3, supports SelfSigned SSL certificates and other fixes. |
|
@Pinox it also fix the NativeCookieHandler. Both Cookie header and SetCookie using the nativecookiehandler, will be merged into a Cookie header by the native message handler. |
|
@alexrainman , would be great if you could include UWP even if it is only for the Selfsigned SSL layer. |
|
@Pinox @Cheesebaron i have released version 2.6.0 with UWP and NetStandard 2.0 support. |
|
@alexrainman much appreciated. Will give it a try and promote further. |
|
I suggest to use https://github.com/alexrainman/ModernHttpClient for all, who want NET Standard compatibile plugin. |
|
@paulcbetts Looks like you've abandoned this project? Last check-in was in 2016. :| @alexrainman Thank you for your contribution. |
|
@adrianknight89 please check modernhttpclient-updated nuget package. |
Includes the fix in #236 to allow Android and the samples to build.
I had to split the solution in different folders because the Droid/iOS projects detected a
project.jsonduring build and that was causing problems.Closes #216
Closes #242