6 Render a project board with columns and tasks #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was
linked to
issues
Dec 2, 2023
Closed
Closed
loganpaulmatheny
approved these changes
Dec 2, 2023
| <Project | ||
| key={project.id} | ||
| title={project.title} | ||
| onClick={() => setSelectedProject(project)} |
| import Column from "../Column/Column"; | ||
| import Task from "../Task/Task"; | ||
|
|
||
| function ProjectBoard({ selectedProject }) { |
There was a problem hiding this comment.
So overall I see what you're doing and this is great! I wonder if we should really be manipulating GS for the selected project though? I'm sure I'm the one that originally had projects being passed down as props
| function ProjectBoard({ selectedProject }) { | ||
| const user = useSelector((state) => state.user.user); | ||
|
|
||
| const projectTasks = selectedProject ? selectedProject.tasks : []; |
There was a problem hiding this comment.
You had to do this because GS is not cognizant of what the selected project is
| return ( | ||
| <> | ||
| <div className="flex flex-col w-10/12"> | ||
| {selectedProject ? <p>{selectedProject.title}</p> : <p>No project selected</p>} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds a ProjectBoard component that based on a selected project, it will render the proper project tasks into 3 columns: Backlog, Doing, and Done
Type of change
Checklist: