Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Light Mode Bug #91

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix Light Mode Bug #91

merged 2 commits into from
Jan 11, 2024

Conversation

joh-ann
Copy link
Contributor

@joh-ann joh-ann commented Jan 10, 2024

Summary:

Adds the use of light mode to Dashboard, ProjectBoard and FileUpload. Imported Redux to each of their respective component files.

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Testing
  • Comment:

Checklist:

  • Code needs to be tested
  • All tests are passing
  • Create new branch AFTER you merge
  • Whats next:

@joh-ann joh-ann self-assigned this Jan 10, 2024
Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analog-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 0:56am

@joh-ann joh-ann changed the title Fix/light mode Fix Light Mode Bug Jan 11, 2024
Copy link
Contributor

@loganpaulmatheny loganpaulmatheny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution. Do you think instead we should have maybe not used ternaries? Would it work if we put back in defaults e.g. bg-white?

@loganpaulmatheny loganpaulmatheny merged commit fd8a6ca into main Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants