Small fix when using write_68, read_68, and cmd_68 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudnimg
commented
Nov 18, 2020
gudnimg
commented
- write_68, read_68, and cmd_68 explicitly define that the command input should be an array with two bytes.
- also fixed a small indent error in LTC681x_stsctrl()
- write_68, read_68, and cmd_68 explicitly define that the command input should be an array with two bytes. - also fixed a small indent error in LTC681x_stsctrl()
This saves about 130 bytes of memory (at least when I compile for ATmega2560 and ATmega2561). The for loop I removed basically just copies data to rx_data with exactly the same indexes so I don't really see why we need data. Simplifies the code a little bit :)
- Changed cmd[4] to cmd[2] in various places.
- Fix for LTC6813_rdpsb(). Now returns proper -1. - Fix potential overflow in LTC6810_rdsid. It also returns proper -1. - Removed unused variables in LTC6810_rds_reg() - LTC681x_rdaux_reg now uses read_68() - LTC681x_rdcv_reg now uses read_68() - LTC681x_rdstat_reg now uses read_68()
|
Closing. I merged this into #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.