spi: spi-axi-spi-engine: setup the timer before IRQ enable #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The watchdog timer was being activated after enabling the interrupts and that could actually lead for the message to be transferred before we get to call mod_timer() which would lead to a spurious soft interrupt. In extreme cases (like playing with overlays to load + unload devices) this could lead to a panic splat as the timer callback would be called with the spi engine device gone already. Fixes: fde5597 ("spi: axi-spi-engine: Add watchdog timer") Signed-off-by: Nuno Sa <[email protected]>
|
This should also fix #2298 |
mhennerich
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The watchdog timer was being activated after enabling the interrupts and that could actually lead for the message to be transferred before we get to call mod_timer() which would lead to a spurious soft interrupt. In extreme cases (like playing with overlays to load + unload devices) this could lead to a panic splat as the timer callback would be called with the spi engine device gone already.
Fixes: fde5597 ("spi: axi-spi-engine: Add watchdog timer")
Note this is also an issue in the main branch but not an issue in the upstream version of the spi-engine @dlech worked on. As I'm expecting the upstream version to be synced in the ADI tree + offload support, I'm not doing this fix in main.