clearer errors on nil/empty config values #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benburkert I've manually tested this, but we should probably add automated tests too. I wasn't quite sure where/how to fit that in to trigger the plugin start (where the errors originate), could use input or to at least talk through it. |
benburkert
reviewed
Jul 16, 2024
There was a problem hiding this comment.
I've manually tested this, but we should probably add automated tests too.
Since the start method is already doing a lot, which makes it a big pain to unit test, how about breaking out the config loading part into a load_config (or whatever) method and unit test that?
|
I think the problem was largely elsewhere, namely: anchordotdev/rails-demo#11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.