Skip to content

Commit

Permalink
feat: remove kubeproxy from node information
Browse files Browse the repository at this point in the history
This field was deprecated in k8s 1.31 as it does not accurately
represent the running version of kube proxy on a node.

Deprecation notice https://kubernetes.io/blog/2024/07/19/kubernetes-1-31-upcoming-changes/#deprecation-of-status-nodeinfo-kubeproxyversion-field-for-nodes-kep-4004-https-github-com-kubernetes-enhancements-issues-4004

More information can be seen here: kubernetes/kubernetes#117756

Signed-off-by: Bradley Jones <[email protected]>
  • Loading branch information
bradleyjones committed Aug 28, 2024
1 parent 2f3009a commit 04f29db
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions pkg/inventory/nodes.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ func FetchNodes(c client.Client, batchSize, timeout int64, includeAnnotations, i
Arch: n.Status.NodeInfo.Architecture,
ContainerRuntimeVersion: n.Status.NodeInfo.ContainerRuntimeVersion,
KernelVersion: n.Status.NodeInfo.KernelVersion,
KubeProxyVersion: n.Status.NodeInfo.KubeProxyVersion,
KubeletVersion: n.Status.NodeInfo.KubeletVersion,
Labels: labels,
OperatingSystem: n.Status.NodeInfo.OperatingSystem,
Expand All @@ -53,7 +52,6 @@ func FetchNodes(c client.Client, batchSize, timeout int64, includeAnnotations, i
Arch: n.Status.NodeInfo.Architecture,
ContainerRuntimeVersion: n.Status.NodeInfo.ContainerRuntimeVersion,
KernelVersion: n.Status.NodeInfo.KernelVersion,
KubeProxyVersion: n.Status.NodeInfo.KubeProxyVersion,
KubeletVersion: n.Status.NodeInfo.KubeletVersion,
OperatingSystem: n.Status.NodeInfo.OperatingSystem,
}
Expand Down
6 changes: 0 additions & 6 deletions pkg/inventory/nodes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ func TestFetchNodes(t *testing.T) {
Architecture: "arm64",
ContainerRuntimeVersion: "docker://20.10.23",
KernelVersion: "5.15.49-linuxkit",
KubeProxyVersion: "v1.26.1",
KubeletVersion: "v1.26.1",
OperatingSystem: "linux",
},
Expand All @@ -71,7 +70,6 @@ func TestFetchNodes(t *testing.T) {
Arch: "arm64",
ContainerRuntimeVersion: "docker://20.10.23",
KernelVersion: "5.15.49-linuxkit",
KubeProxyVersion: "v1.26.1",
KubeletVersion: "v1.26.1",
OperatingSystem: "linux",
},
Expand All @@ -97,7 +95,6 @@ func TestFetchNodes(t *testing.T) {
Architecture: "arm64",
ContainerRuntimeVersion: "docker://20.10.23",
KernelVersion: "5.15.49-linuxkit",
KubeProxyVersion: "v1.26.1",
KubeletVersion: "v1.26.1",
OperatingSystem: "linux",
},
Expand All @@ -117,7 +114,6 @@ func TestFetchNodes(t *testing.T) {
Arch: "arm64",
ContainerRuntimeVersion: "docker://20.10.23",
KernelVersion: "5.15.49-linuxkit",
KubeProxyVersion: "v1.26.1",
KubeletVersion: "v1.26.1",
OperatingSystem: "linux",
},
Expand Down Expand Up @@ -145,7 +141,6 @@ func TestFetchNodes(t *testing.T) {
Architecture: "arm64",
ContainerRuntimeVersion: "docker://20.10.23",
KernelVersion: "5.15.49-linuxkit",
KubeProxyVersion: "v1.26.1",
KubeletVersion: "v1.26.1",
OperatingSystem: "linux",
},
Expand All @@ -165,7 +160,6 @@ func TestFetchNodes(t *testing.T) {
Arch: "arm64",
ContainerRuntimeVersion: "docker://20.10.23",
KernelVersion: "5.15.49-linuxkit",
KubeProxyVersion: "v1.26.1",
KubeletVersion: "v1.26.1",
OperatingSystem: "linux",
Annotations: map[string]string{
Expand Down

0 comments on commit 04f29db

Please sign in to comment.