Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds periodic health reporting to the k8s inventory agent #244

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat: adds periodic health reporting to the k8s inventory agent #244

merged 1 commit into from
Oct 18, 2024

Conversation

bobmel
Copy link
Contributor

@bobmel bobmel commented Jul 5, 2024 •
edited
Loading

Addresses: Enterprise-2483

@bobmel bobmel requested a review from a team as a code owner July 5, 2024 10:32
@bobmel bobmel marked this pull request as draft July 10, 2024 10:40
@bobmel bobmel force-pushed the bmelander/ENTERPRISE-4118 branch 2 times, most recently from 42ea730 to c464999 Compare September 11, 2024 08:55
bradleyjones
bradleyjones reviewed Oct 2, 2024
View reviewed changes
anchore-k8s-inventory.yaml Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/anchore/anchoreclient.go Show resolved Hide resolved
@bobmel bobmel marked this pull request as ready for review October 7, 2024 08:07
@bobmel bobmel force-pushed the bmelander/ENTERPRISE-4118 branch 2 times, most recently from 5d49fe5 to da3b770 Compare October 9, 2024 12:53
@bobmel
feat: adds periodic health reporting to the k8s inventory agent
b458e9d 
Addresses: Enterprise-2483

Signed-off-by: Bob Melander <[email protected]>
bradleyjones
bradleyjones approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@bradleyjones bradleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look great, let's get this in and some soak time in a beta release. Ping me tomorrow and I can assist with the beta

@bobmel
Copy link
Contributor Author

bobmel commented Oct 18, 2024

Thanks Brad for reviewing this!

@bobmel bobmel merged commit 55e7526 into main Oct 18, 2024
4 checks passed
@bobmel bobmel deleted the bmelander/ENTERPRISE-4118 branch October 18, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradleyjones bradleyjones bradleyjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobmel @bradleyjones