-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: separate tagged image providers #219
Merged
kzantow
merged 26 commits into
anchore:main
from
kzantow-anchore:feat/tagged-image-providers
Feb 21, 2024
Merged
feat: separate tagged image providers #219
kzantow
merged 26 commits into
anchore:main
from
kzantow-anchore:feat/tagged-image-providers
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Feb 6, 2024
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Feb 7, 2024
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
yeah, I think so |
I'm a fan of "provider" here, but will give it some thoughts |
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
reviewed
Feb 8, 2024
wagoodman
reviewed
Feb 8, 2024
wagoodman
reviewed
Feb 8, 2024
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Feb 9, 2024
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
reviewed
Feb 15, 2024
wagoodman
reviewed
Feb 15, 2024
wagoodman
reviewed
Feb 15, 2024
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following top-level changes:
image.Provider
interface has been reworked so providers haveName()
methodimage.Provider.Provide
is required to return an image object fully populated (e.g..Read()
has been called)stereoscope.ImageProviders
function is added, allowing interested parties (e.g. syft) to get access to the individual tagged image providersstereoscope.ImageProviderConfig
is added which is the uber-configuration needed by all stereoscope-defined providersNote: the top-level
GetImage
andGetImageFromSource
remain unchanged with the caveat that theimage.Source
has changed from anint
to astring
. These functions will use the default set of image providers, so should continue to behave about the same as before, with the other caveat that if the user has a docker daemon and another supported daemon (containerd, podman), each daemon may be tried instead of stopping after attempting docker, which is the behavior today.TODO:
should(no, this is nowimage.Provider
have aTags() []string
method andImageProviders(...)
returns[]image.Provider
?[]collections.TaggedValue[image.Provider]
)--from
flag syft#2610