Add label collection to help with multiple label comparisons #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
| @@ -499,6 +500,15 @@ def effective_year(self, by_cve=False) -> Optional[int]: | |||
| return year | |||
|
|
|||
|
|
|||
| class LabelEntryCollection: | |||
There was a problem hiding this comment.
I'm confused. Is this meant to be used as the type of label_entries in src/yardstick/__init__.py?
There was a problem hiding this comment.
not in this PR, no. This PR only adds this object to be used by API consumers. In the future this can be rolled underneath the core API.
Signed-off-by: Alex Goodman <[email protected]>
spiffcs
approved these changes
Aug 17, 2023
Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today it's easy to load all of the labels needed for an image and pass them into the comparison helpers. However, doing that will result in slow comparisons without it being clear as to why. In the future more logic can be added around the core objects to make it hard to misuse, but in the meantime a convenience
LabelEntryCollectionhas been added by this PR to allow an API user to filter already loaded labels before a comparison is done.Note: this uses
functools.cachewhich was introduced in python 3.9, so the requirements were changed.Additionally: