Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat validate subcommand #380

Merged
merged 32 commits into from
Sep 20, 2024
Merged

Feat validate subcommand #380

merged 32 commits into from
Sep 20, 2024

Conversation

willmurphyscode
Copy link
Contributor

@willmurphyscode willmurphyscode commented Aug 28, 2024

Migrates many of the gate.py in multiple repos to a new subcommand validate, which takes a result set of reference and candidate changes, a validation configuration (within yardstick.yaml) and when invoked gives a pass/fail indication.

Fixes #126

TODOs

reference, candidate = "", ""
for t in self.matrix.tools:
if t.validation_role == "candidate":
candidate = f"{t.name}@{t.version}"
Copy link
Contributor Author

@willmurphyscode willmurphyscode Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to return the same string as the tool version that's in .tools on a ScanResult, but nothing enforces this and it doesn't seem to always be true.

Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
This is needed for the Vunnel changes.

Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
@willmurphyscode willmurphyscode marked this pull request as ready for review September 20, 2024 14:05
@willmurphyscode willmurphyscode merged commit fe6ae0f into main Sep 20, 2024
3 checks passed
@willmurphyscode willmurphyscode deleted the feat-validate-subcommand branch September 20, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add yardstick validate subcommand
2 participants