Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide_context fn #76

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

topaxi
Copy link
Contributor

@topaxi topaxi commented Jul 16, 2024

I want to explicitly hide or show context virtual texts, M.toggle_context() is not covering that case, as I can't provide the state I want it to be in.

Not sure whether this is enough, or whether I should also set opts.enabled in each fn, similar to what M.toggle_context() does, but instead in their respective methods.

Copy link
Owner

@andersevenrud andersevenrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@andersevenrud andersevenrud merged commit 03fb506 into andersevenrud:master Jul 16, 2024
3 checks passed
@andersevenrud
Copy link
Owner

Not sure whether this is enough

Let me know and we'll work something out :)

@topaxi topaxi deleted the hide_fn branch July 16, 2024 20:16
@andersevenrud
Copy link
Owner

, or whether I should also set opts.enabled in each fn, similar to what M.toggle_context() does, but instead in their respective methods.

Alternatively, the toggle_context could take an optional argument to set the enabled state instead of flipping it like it does now.

@topaxi
Copy link
Contributor Author

topaxi commented Jul 16, 2024

Yeah I was thinking of just adding an arg. I'll double check with my configuration tomorrow and might open another PR :)

Thanks for the quick response <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants