Fix for Android mobile browsers: soft keyboards do not send key events except for ENTER so we just take the last line from textarea without the prompt prefix + fix for iOS mobile browsers: soft keyboard did not show on some iOS versions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for ENTER so we just take the last line from textarea without the prompt prefix
markostamcar
changed the title
|
I have now commited the iOS Safari keyboard fix, too :) |
markostamcar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Still having trouble on some iOS versions where the soft keyboard won't open at all but since I don't own any iOS device, it's hard to test. Will be trying using iOS 12 demo at https://appetize.io/demo