Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace label and break with defer and return #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace label and break with defer and return #2

wants to merge 1 commit into from

Conversation

boppreh
Copy link

@boppreh boppreh commented Jun 6, 2014

Labels and outer breaks are not very elegant, so I'm proposing using a simple return instead of the break and deferring the stop() using a language feature. This makes clear that stop() is a cleanup action and the code inside the main loop doesn't have to worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant