Accept Standard Before/After Behat tags

andrewnicols · Mar 19, 2024 · 6b37c7e · 6b37c7e
1 parent 23ee080
commit 6b37c7e
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 0 deletions.
diff --git a/moodle/Tests/Util/DocblocksTest.php b/moodle/Tests/Util/DocblocksTest.php
@@ -196,6 +196,46 @@ function exampleFunction(string $param): void {}',
                 function exampleFunction(string $param): void {}',
                 true,
             ],
+            'Behat test file: Valid' => [
+                'lib/tests/behat/behat_example.php',
+                '<?php
+                class behat_example {
+                    /**
+                     * @BeforeScenario
+                     * @AfterScenario
+                     * @BeforeFeature
+                     * @AfterFeature
+                     * @BeforeStep
+                     * @AfterStep
+                     * @Given
+                     * @When
+                     * @Then
+                     * @Given
+                     */
+                    function exampleFunction(string $param): void {}
+                }',
+                true,
+            ],
+            'Unit test file: Contains Behat' => [
+                'lib/tests/test_behat.php',
+                '<?php
+                class test_behat {
+                    /**
+                     * @BeforeScenario
+                     * @AfterScenario
+                     * @BeforeFeature
+                     * @AfterFeature
+                     * @BeforeStep
+                     * @AfterStep
+                     * @Given
+                     * @When
+                     * @Then
+                     * @Given
+                     */
+                    function exampleFunction(string $param): void {}
+                }',
+                false,
+            ],
         ];
     }
 

diff --git a/moodle/Util/Docblocks.php b/moodle/Util/Docblocks.php
@@ -37,6 +37,12 @@ abstract class Docblocks
         'Given' => true,
         'Then' => true,
         'When' => true,
+        'BeforeFeature' => true,
+        'BeforeScenario' => true,
+        'BeforeStep' => true,
+        'AfterFeature' => true,
+        'AfterScenario' => true,
+        'AfterStep' => true,
 
         // PHPUnit tags.
         'codeCoverageIgnore' => true,
@@ -118,6 +124,13 @@ abstract class Docblocks
         'Given' => ['#.*/tests/behat/.*#'],
         'Then' => ['#.*/tests/behat/.*#'],
         'When' => ['#.*/tests/behat/.*#'],
+        'BeforeFeature' => ['#.*/tests/behat/.*#'],
+        'BeforeScenario' => ['#.*/tests/behat/.*#'],
+        'BeforeStep' => ['#.*/tests/behat/.*#'],
+        'AfterFeature' => ['#.*/tests/behat/.*#'],
+        'AfterScenario' => ['#.*/tests/behat/.*#'],
+        'AfterStep' => ['#.*/tests/behat/.*#'],
+
         'covers' => ['#.*/tests/.*_test.php#'],
         'coversDefaultClass' => ['#.*/tests/.*_test.php#'],
         'coversNothing' => ['#.*/tests/.*_test.php#'],