Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update switch_trains.rb #1

Closed
wants to merge 1 commit into from
Closed

Update switch_trains.rb #1

wants to merge 1 commit into from

Conversation

andrewzwicky
Copy link
Owner

@andrewzwicky andrewzwicky commented Feb 21, 2024

Add the include for Lib::Settings to get the right functions available to use the color_for function. I checked all the other places, they are all correct.

Fixes tobymao#10378

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Explanation of Change

    Add the right includes to ensure color_for is available.

  • Screenshots

    game 151777 rendering at latest action
    image

  • Any Assumptions / Hacks

Add the include for Lib::Settings to get the right functions available to use the color_for function.  I checked all the other places, they are all correct.
andrewzwicky pushed a commit that referenced this pull request Aug 14, 2024
An error was occurring when attempting to token the brown Ruhr tile
(3-slot city). There was already a token in slot #0. If the player
clicks on slot #1 when placing a token this worked correctly, but
clicking on slot tobymao#2 errored, as the game was then attempting to change
the logo of the token in slot tobymao#2, but the token had gone to slot #1.

Fixes ollybh#133.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Game 151777] Will not Load
1 participant