Добавить поддержку IR. #374

georgiy-belyanin · 2023-03-21T12:00:46Z

Реализовал часть основных IR функций. Этот PR не влияет на существующие методы генерации, он содержит только код потенциально применимый для построения этого дерева, чтобы ничего не сломать из существующего.

bugdea1er · 2023-03-21T14:45:29Z

libs/compiler/ir.h

+ *	значения, используемые в инструкциях функций. Фактически эквивалентен единице 
+ *	трансляции.
+ */
+typedef struct ir_module


А где очистка

…ions.

…valuation with this.

…ses.

…ration.

IvanArkhipov1999 · 2023-04-18T14:24:58Z

libs/compiler/ir.c

+static extern_data create_extern_data(const item_t id, const item_t type)
+{
+	return (extern_data) {
+		.id = id,
+		.type = type
+	};
+}


Как-нибудь отделить static

IvanArkhipov1999 · 2023-04-18T14:28:29Z

libs/compiler/ir.c

+static char* ir_imm_value_get_string(const ir_value *const value)
+{
+	(void) value;
+	return NULL;
+}


Что-то странное

IvanArkhipov1999 · 2023-04-18T14:29:38Z

libs/compiler/ir.c

+static item_t ir_value_save(const ir_value *const value)
+{
+	return (item_t) node_save(value);
+}


Зачем преобразование

IvanArkhipov1999 · 2023-04-18T14:34:14Z

libs/compiler/ir.c

+static item_t ir_build_param(ir_builder *const builder, const item_t type, size_t number)
+{
+	const ir_value value = create_ir_param_value(&builder->module->values_root, type, number);
+	//ir_locals_add(builder, type);


Убрать

IvanArkhipov1999 · 2023-04-18T14:35:21Z

libs/compiler/ir.c

+	ir_instr instr = create_ir_instr(&function, ic, op1, op2, res);
+	(void) instr;


Зачем заводить переменную?

IvanArkhipov1999 · 2023-04-18T14:35:46Z

libs/compiler/ir.c

+
+static item_t ir_build_ptr(ir_builder *const builder, const item_t type, const item_t base, const size_t displ)
+{
+	(void) displ;


IvanArkhipov1999 · 2023-04-18T14:37:27Z

libs/compiler/ir.c

+		{
+
+			break;
+		}


Можно и без скобок

IvanArkhipov1999 · 2023-04-18T14:37:46Z

libs/compiler/ir.c

+}
+static void ir_dump_ic(const ir_builder *const builder, const ir_ic ic)
+{
+	(void) builder;


IvanArkhipov1999 · 2023-04-18T14:38:41Z

libs/compiler/ir.c

+
+static void ir_dump_label_kind(const ir_builder *const builder, const ir_label_kind label_kind)
+{
+	(void) builder;


IvanArkhipov1999 · 2023-04-18T14:42:27Z

libs/compiler/ir.c

+	const item_t type = expression_get_type(nd);
+
+	(void) type;


IvanArkhipov1999 · 2023-04-18T14:43:16Z

libs/compiler/ir.c

+	const item_t return_type = type_function_get_return_type(sx, expression_get_type(&callee));
+	(void) return_type;


IvanArkhipov1999 · 2023-04-18T14:44:49Z

libs/compiler/ir.c

+	else
+	{
+		const item_t operand_rvalue = ir_build_load(builder, operand_lvalue);
+		const item_t second_value = ir_build_imm_one(builder);
+		const item_t incremented_value = ir_emit_binary_operation(builder, operand_rvalue, second_value, (is_inc) ? BIN_ADD : BIN_SUB);
+		ir_free_value(builder, second_value);
+
+		ir_build_store(builder, incremented_value, operand_lvalue);
+		ir_free_value(builder, incremented_value);
+
+		return operand_rvalue;
+	}
+
+	return IR_VALUE_VOID;


Можно else не ставить

IvanArkhipov1999 · 2023-04-18T14:46:13Z

libs/compiler/ir.c

+		{
+			const node operand = expression_unary_get_operand(nd);
+			const item_t value = ir_emit_expression(builder, &operand);
+			//const item_t second_value = builder->value_zero;


Комменты с кодом удалять

IvanArkhipov1999 · 2023-04-18T14:47:17Z

libs/compiler/ir.c

+			const node operand = expression_unary_get_operand(nd);
+
+			(void) operand;


IvanArkhipov1999 · 2023-04-18T14:47:42Z

libs/compiler/ir.c

+		{
+			if (type_is_integer(sx, lhs_type) && type_is_integer(sx, rhs_type))
+			{
+				//printf("%d %d\n", lhs, rhs);


Код в комментах

IvanArkhipov1999 · 2023-04-18T14:48:13Z

libs/compiler/ir.c

+				return ir_build_add(builder, lhs, rhs);
+			}
+			else 
+			{
+				const item_t lhs_value = type_is_floating(lhs_type) ? lhs : ir_build_itof(builder, lhs);
+				const item_t rhs_value = type_is_floating(rhs_type) ? rhs : ir_build_itof(builder, rhs);
+				return ir_build_fadd(builder, lhs_value, rhs_value);
+			}


без else

IvanArkhipov1999 · 2023-04-18T14:50:13Z

libs/compiler/ir.c

+	const syntax *const sx = builder->sx;
+	(void) sx;


IvanArkhipov1999 · 2023-04-18T14:50:34Z

libs/compiler/ir.c

+	const item_t rhs_type = expression_get_type(&rhs);
+	(void) rhs_type;


IvanArkhipov1999 · 2023-04-18T14:51:30Z

libs/compiler/ir.c

+	// const syntax *const sx = builder->sx;
+
+	// const size_t member_amount = type_structure_get_member_amount(sx, target->type);
+
+	// for (size_t i = 0; i < member_amount; i++)
+	// {
+	// 	const item_t type = type_structure_get_member_type(sx, target->type, i);
+	// 	const lvalue member_lvalue = {
+	// 		.base_reg = target->base_reg,
+	// 		.kind = target->kind,
+	// 		.loc.displ = target->loc.displ + displ,
+	// 		.type = type
+	// 	};
+	// 	displ += type_size(sx, type);
+
+	// 	const node subexpr = expression_initializer_get_subexpr(initializer, i);
+	// 	if (expression_get_class(&subexpr) == EXPR_INITIALIZER)
+	// 	{
+	// 		ir_emit_structure_init(builder, &member_lvalue, &subexpr);
+	// 		continue;
+	// 	}
+
+	// 	if (type_is_structure(sx, expression_get_type(&subexpr)))
+	// 	{
+	// 		ir_emit_struct_assignment(builder, &member_lvalue, &subexpr);
+	// 	}
+	// 	else


Ужас, удаляю

IvanArkhipov1999 · 2023-04-18T14:53:08Z

libs/compiler/ir.c

+static void ir_emit_function_definition(ir_builder *const builder, const node *const nd)
+{
+	const syntax *const sx = builder->sx;
+	const item_t id = (item_t) declaration_function_get_id(nd);


Нужен size_t

IvanArkhipov1999 · 2023-04-18T14:53:31Z

libs/compiler/ir.c

+
+	ir_emit_statement(builder, &body);
+
+	// ir_build_ret(builder, IR_VALUE_VOID);


Код в комментах

IvanArkhipov1999 · 2023-04-18T14:55:20Z

libs/compiler/ir.c

+	const item_t begin_label = ir_add_label(builder, IR_LABEL_KIND_BEGIN_CYCLE);
+	const item_t end_label = ir_add_label(builder, IR_LABEL_KIND_END);
+
+	const item_t old_continue = builder->continue_label;
+	const item_t old_break = builder->break_label;


Кажется, метки тоже можно сделать size_t

IvanArkhipov1999 · 2023-04-18T14:59:03Z

libs/compiler/ir.c

+static ir_gen_rl_instr_func ir_get_rl_instr_gen(const ir_context *const ctx, const ir_instr *const instr)
+{
+	(void) ctx;
+
+	const ir_ic ic = ir_instr_get_ic(instr);
+
+	switch (ic)
+	{
+		default:
+			unreachable();
+			return NULL;
+	}
+}


Если не надо, то и зачем

IvanArkhipov1999 · 2023-04-18T14:59:32Z

libs/compiler/ir.c

+static ir_gen_fn_instr_func ir_get_fn_instr_gen(const ir_context *const ctx, const ir_instr *const instr)
+{
+	(void) ctx;
+
+	const ir_ic ic = ir_instr_get_ic(instr);
+
+	switch (ic)
+	{
+		default:
+			unreachable();
+			return NULL;
+	}
+}


Если не надо, то зачем

IvanArkhipov1999 · 2023-04-18T15:06:18Z

libs/compiler/mipsgen.c

+	//const lvalue param_value = create_param_lvalue(i);
+	//mips_gen_store(enc, value, param_value);


Код в комментах

IvanArkhipov1999 · 2023-04-18T15:07:13Z

libs/compiler/mipsgen.c

-	if (!ws_is_correct(ws) || sx == NULL)
-	{
-		return -1;
-	}
+	(void) ws;



А почему удалили?

georgiy-belyanin added 3 commits March 21, 2023 14:51

Add some basic IR functionality.

f8b4966

Remove unrelated old comment.

5f82ce9

Remove old comments from ir.c.

52678dd

georgiy-belyanin force-pushed the feature-ir branch 2 times, most recently from 9842f62 to 6908dcb Compare March 21, 2023 13:51

Add some support for unary expressions.

10e50c7

georgiy-belyanin force-pushed the feature-ir branch from 6908dcb to 10e50c7 Compare March 21, 2023 14:03

bugdea1er reviewed Mar 21, 2023

View reviewed changes

georgiy-belyanin added 8 commits March 22, 2023 16:57

Change ir_value const type name to immediate.

abeb73e

Change rvalue kind const name to imm.

380bb01

Move ir_module and ir_builder definition to .c file instead of .h.

10a7f60

Add labels that are passed to platform-specific code generation funct…

8ca1416

…ions.

Hotfix ir_label vars names not to be the same with a new struct name.

1d60494

Add doxygen group for ir.h, fix docs for ir_dump().

3c277dc

Provide IR instruction codes with their kinds, simplify dumping and e…

9670a51

…valuation with this.

Add support of local variables.

98e7a1d

georgiy-belyanin marked this pull request as draft March 28, 2023 11:58

georgiy-belyanin added 8 commits March 31, 2023 02:54

Add support for unary and binary expressions in IR.

c476db8

Update mipsgen to dump IR instead of codegeneration for testing purpo…

22b796e

…ses.

Add support for mips code generation and extend ir functionality.

7505d4e

Add support for binary operations in IR tree.

c2c947e

Hotfix errors in register generation.

79684c3

Fix increment emmiting in IR. Add suport for basic function mips gene…

09423bc

…ration.

Add support for strings, partial support for structs.

b2392dc

Remove IR tree dump.

34d741f

georgiy-belyanin force-pushed the feature-ir branch from e99b82e to 34d741f Compare April 18, 2023 13:28

IvanArkhipov1999 reviewed Apr 18, 2023

View reviewed changes

libs/compiler/ir.c Outdated

Comment on lines 1521 to 1524

{

break;

}

Copy link

Collaborator

IvanArkhipov1999 Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно и без скобок

IvanArkhipov1999 reviewed Apr 18, 2023

View reviewed changes

libs/compiler/ir.c

Comment on lines +2877 to +2878

const syntax *const sx = builder->sx;

(void) sx;

Copy link

Collaborator

IvanArkhipov1999 Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зочем

IvanArkhipov1999 reviewed Apr 18, 2023

View reviewed changes

Done some cleanup and hotfixes in mipsgen and ir.

d97e750

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Добавить поддержку IR. #374

Добавить поддержку IR. #374

georgiy-belyanin commented Mar 21, 2023

bugdea1er Mar 21, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

IvanArkhipov1999 Apr 18, 2023

		ir_instr instr = create_ir_instr(&function, ic, op1, op2, res);
		(void) instr;

+              		{
+              			break;
+              		}

		const item_t return_type = type_function_get_return_type(sx, expression_get_type(&callee));
		(void) return_type;

		const node operand = expression_unary_get_operand(nd);

		(void) operand;

		const item_t rhs_type = expression_get_type(&rhs);
		(void) rhs_type;


		ir_emit_statement(builder, &body);

		// ir_build_ret(builder, IR_VALUE_VOID);

		//const lvalue param_value = create_param_lvalue(i);
		//mips_gen_store(enc, value, param_value);

Добавить поддержку IR. #374

Are you sure you want to change the base?

Добавить поддержку IR. #374

Conversation

georgiy-belyanin commented Mar 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment