This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Replace additional function with custom matcher for better assertion errors. #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project doesn't use Jetpack DataStore.
|
@mlykotom , excuse me, are you here? |
arriolac
reviewed
Sep 14, 2023
app/src/test/java/com/google/samples/apps/sunflower/test/HasSameDateWith.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| override fun matchesSafely(actual: Calendar?, mismatchDescription: Description?): Boolean { | ||
| return (actual?.let { |
There was a problem hiding this comment.
This is a bit difficult to read. I recommend returning early using an if statement to check if actual is null
There was a problem hiding this comment.
I was thinking more along the lines of:
if (actual == null)
return false
if (actual.get(YEAR) == expected.get(YEAR) && actual.get(MONTH) == expected.get(MONTH) && actual.get(DAY_OF_MONTH) == expected.get(DAY_OF_MONTH))
return true
mismatchDescription?.appendText("was ")?.appendText(actual?.time?.let { formatter.format(it) } ?: "null")
return false
}
app/src/test/java/com/google/samples/apps/sunflower/test/HasSameDateWith.kt
Outdated
Show resolved
Hide resolved
|
@arriolac excuse me, can you check this PR again (resolve conversations if problems are solved or left new comments) ? |
arriolac
suggested changes
Oct 19, 2023
gradle/libs.versions.toml
Outdated
| @@ -16,7 +16,7 @@ | |||
| [versions] | |||
| accessibilityTestFramework = "4.0.0" | |||
| activityCompose = "1.7.2" | |||
| androidGradlePlugin = "8.0.2" | |||
| androidGradlePlugin = "8.1.1" | |||
There was a problem hiding this comment.
Please revert. While I agree with this change, I'd prefer to have it as a separate PR and commit.
| } | ||
|
|
||
| override fun matchesSafely(actual: Calendar?, mismatchDescription: Description?): Boolean { | ||
| return (actual?.let { |
There was a problem hiding this comment.
I was thinking more along the lines of:
if (actual == null)
return false
if (actual.get(YEAR) == expected.get(YEAR) && actual.get(MONTH) == expected.get(MONTH) && actual.get(DAY_OF_MONTH) == expected.get(DAY_OF_MONTH))
return true
mismatchDescription?.appendText("was ")?.appendText(actual?.time?.let { formatter.format(it) } ?: "null")
return false
}
app/src/test/java/com/google/samples/apps/sunflower/test/HasSameDateWith.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR if
GardenPlantingTestthrows an error, it were possible only to see errors like this:I add custom matcher and now it's easier to read assertion errors stack traces.
Additional advantage of this way is that asserts become more readable.
I also add visibility modifier internal for all unit-test classes, because they should have less visibility.