This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Separate navigation routes and args issue #863 #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arriolac
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Thanks! Just one small suggestion on the file's location. Other than that, LGTM.
For reference for other folks reading this PR, you can also reference now NiA structures routes/screens. For example: https://github.com/android/nowinandroid/blob/main/feature/bookmarks/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/BookmarksScreen.kt#L80
| import androidx.navigation.NavType | ||
| import androidx.navigation.navArgument | ||
|
|
||
| sealed class Screen( |
There was a problem hiding this comment.
Rather than putting this under the utilities package, I recommend adding this in compose package.
There was a problem hiding this comment.
Thanks, I've addressed the feedback in commit 'Moved Screen class to compose package'. Could you take a look, @arriolac ?
arriolac
approved these changes
Nov 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate navigation routes and args issue #863