This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Enable e2e. #933
Merged
Enable e2e. #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I777b0977dcdeda3101d412354cb14e1d8f41b634
riggaroo
reviewed
Nov 21, 2023
| HomePagerScreen( | ||
| onPlantClick = onPlantClick, | ||
| pagerState = pagerState, | ||
| modifier = Modifier.padding(it) | ||
| Modifier.padding(top = contentPadding.calculateTopPadding()) |
There was a problem hiding this comment.
Did you add padding to the bottom of the screen too so it can scroll the content out from underneath the bar?
There was a problem hiding this comment.
There's already padding applied so it offsets correctly when you scroll all the way down in the plant list screen: https://github.com/android/sunflower/blob/main/app/src/main/java/com/google/samples/apps/sunflower/compose/plantlist/PlantListScreen.kt#L58
...though technically it doesn't take into account imePadding so let me add that.
Edit: Done in fedc539
Change-Id: I5180f86eb5aea9cee8ba19264488ca9e638b3d66
riggaroo
approved these changes
Nov 22, 2023
This was referenced Dec 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable edge-to-edge on Sunflower.
