Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Update Glide implementation and item key ID. #941

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Update Glide implementation and item key ID. #941

merged 3 commits into from
Dec 28, 2023

Conversation

arriolac
Copy link
Contributor

@arriolac arriolac commented Dec 21, 2023 •
edited
Loading

  • Update Glide to the latest version. The latest version also removed support for passing another composable as a placeholder for performance reasons. So I've updated the placeholder to show a color instead.
  • Fixed a crash in the gallery screen - regression introduced when updating to paging compose

@arriolac
Update Glide implementation and item key ID.
fcd4292 
Change-Id: I3d9182d209ac85dc338f2b7b123b2a788e4453ed
@arriolac arriolac requested a review from a team as a code owner December 21, 2023 00:45
@arriolac
Copy link
Contributor Author

Fixes #942

@hanxiaofeng
Copy link

#942 I do not know how to solved this problem , update gilde is not Available，help!!!

@arriolac arriolac merged commit 9a00783 into main Dec 28, 2023
2 checks passed
@arriolac arriolac deleted the chris/glide_update branch December 28, 2023 16:45
@arriolac arriolac mentioned this pull request Dec 28, 2023
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MagicalMeghan MagicalMeghan MagicalMeghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arriolac @hanxiaofeng @MagicalMeghan