[WIP] Skip building on TruffleRuby #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
force-pushed
the
ak/skip-compiling-on-truffleruby
branch
from
504e1a2
to
0d6b27c
Compare
eregon
reviewed
Sep 17, 2024
ext/fiddle/extconf.rb
Outdated
| LIBFFI_CLEAN = libffi | ||
| MK | ||
| else | ||
| File.write('Makefile', dummy_makefile("").join) |
There was a problem hiding this comment.
There is a ton of logic above we don't want to do.
So check very early the RUBY_ENGINE, just before require 'mkmf' and if no "ruby" then do this + return
andrykonchin
force-pushed
the
ak/skip-compiling-on-truffleruby
branch
from
0d6b27c
to
1d2a34b
Compare
eregon
reviewed
Sep 17, 2024
| require 'fiddle.so' | ||
| else | ||
| $LOAD_PATH.delete(__dir__) | ||
| require 'fiddle' # load from stdlib |
There was a problem hiding this comment.
You also need to return after this to skip the logic below
andrykonchin
force-pushed
the
ak/skip-compiling-on-truffleruby
branch
6 times, most recently
from
2e2da6d
to
bbd2898
Compare
andrykonchin
force-pushed
the
ak/skip-compiling-on-truffleruby
branch
from
bbd2898
to
b7bdab5
Compare
andrykonchin
force-pushed
the
ak/skip-compiling-on-truffleruby
branch
from
b7bdab5
to
3f6ac2b
Compare
eregon
force-pushed
the
ak/skip-compiling-on-truffleruby
branch
from
2ff4d4c
to
3f6ac2b
Compare
* This is necessary to run Fiddle tests on non-CRuby.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.