Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better optional values handling #430

Merged
merged 10 commits into from
Oct 5, 2024
Merged

Conversation

andrzejressel
Copy link
Owner

Closes #414

examples/simple/src/lib.rs Fixed Show fixed Hide fixed
@andrzejressel andrzejressel changed the title WIP: Better optional values handling Better optional values handling Oct 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 98.70690% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.04%. Comparing base (974a800) to head (cb65711).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pulumi_wasm_core/src/nodes.rs 71.42% 2 Missing ⚠️
pulumi_wasm_core/src/pulumi/service_impl.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   77.95%   80.04%   +2.09%     
==========================================
  Files          25       25              
  Lines        2654     2872     +218     
==========================================
+ Hits         2069     2299     +230     
+ Misses        585      573      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrzejressel andrzejressel added the ready-to-merge Will be auto-merged by mergify label Oct 5, 2024
@mergify mergify bot merged commit 5907c6b into main Oct 5, 2024
11 checks passed
@mergify mergify bot deleted the better-optional-values-handling branch October 5, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Will be auto-merged by mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support optional values during non-preview run
2 participants