Auto refresh service resource on change in bp.conf

[pythiankowalczyk]

…f service after changes in config file.

Closes #9.

[stivesso]

Thanks Piotr,

But I was more thinking about changing the require below ( On the 'netbackup-client' service ) to subscribe (subscribe — Applies a resource after the target resource. The subscribing resource refreshes if the target resource changes.) The main difference with the approach you proposed is that I am still keeping only one metaparameter for this relationship (which will be subscribe) instead of two (notify and require). Let me know what you think about that (see what it will look like below).

  file { 'bp.conf':
    ensure  => file,
    path    => '/usr/openv/netbackup/bp.conf',
    owner   => 'root',
    group   => 'root',
    mode    => '0644',
    content => template('netbackup/bp.conf.erb'),
  }

  # Only define netbackup init service if netbackup_version fact is set
  if $::netbackup_version != undef {
    service { 'netbackup-client':
      ensure     => $service_enabled,
      name       => 'netbackup',
      hasrestart => false,
      hasstatus  => false,
      pattern    => 'bpcd',
      provider   => $service_provider,
      require    => File['bp.conf']
    }
  }

With subscribe instead of require:

  file { 'bp.conf':
    ensure  => file,
    path    => '/usr/openv/netbackup/bp.conf',
    owner   => 'root',
    group   => 'root',
    mode    => '0644',
    content => template('netbackup/bp.conf.erb'),
  }

  # Only define netbackup init service if netbackup_version fact is set
  if $::netbackup_version != undef {
    service { 'netbackup-client':
      ensure      => $service_enabled,
      name        => 'netbackup',
      hasrestart => false,
      hasstatus  => false,
      pattern     => 'bpcd',
      provider   => $service_provider,
      subscribe => File['bp.conf']
    }
  }

[SohamChakraborty]

Steve, good catch. I like your approach. I will let Piotr comment what he thinks, but I am also in favor of having one metaparameter instead of two and specially so when one metaparameter can do the job.

[pythiankowalczyk]

Steve, you're right, subscribe will be more than enough here. It looks good. Thanks!

…

On Sun, Jun 25, 2017 at 10:04 AM, Soham Chakraborty < ***@***.***> wrote: Steve, good catch. I like your approach. I will let Piotr comment what he thinks, but I am also in favor of having one metaparameter instead of two and specially so when one metaparameter can do the job. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK5WEsXpTIPiR9OLlzX-NdunKWcYBS4hks5sHhSogaJpZM4OEWIi> .

-- Piotr Kowalczyk Systems Administrator EIS Pythian - Love your Data Phone: +1 613 565 8696 x1238 Mobile: +48 602 376 842

--

--

[andskli]

@pythiankowalczyk will you update this PR with the suggested changes from @stivesso?

[pythiankowalczyk]

@andskli here you go.

[andskli]

Thank you. I took myself the liberty to actually update the description of this PR etc.

@stivesso you happy with this? If so LGTM once tests have passed.

[pythiankowalczyk]

Thank you all.

…

On Mon, Jun 26, 2017 at 4:33 PM, Andreas Skarmutsos Lindh < ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK5WEqCvHgY67RSctr-CzBKevfumxgtQks5sH8E5gaJpZM4OEWIi> .

-- Piotr Kowalczyk Systems Administrator EIS Pythian - Love your Data Phone: +1 613 565 8696 x1238 Mobile: +48 602 376 842

--

--

[andskli]

I'm reopening this PR so that it can be merged.

[SohamChakraborty]

Andreas, Would you also please add a forge release when it is merged?

…

On Mon, Jun 26, 2017 at 8:16 PM, Andreas Skarmutsos Lindh < ***@***.***> wrote: Reopened #10 <#10>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACXSZu5nhYLvBBqoIZ5xDVuBG1rths1Wks5sH8RhgaJpZM4OEWIi> .

-- Soham Chakraborty, Systems Administrator - EIS Pythian - Love your data [email protected]

--

--

[andskli]

@SohamChakraborty see #11. I'll look into it.

[stivesso]

Hi Andreas,

LGTM! Thanks Guyz...