Port dialogs/popups to AdwDialog counterparts #628
Conversation
|
commitlint needs to be fixed, just needs to be lower-case, e.g. Basically just the Flatpak (Unstable) needs to pass right now, then I'll figure out what to do. It might be time to start branching when the run-time branches 🤔 |
sungsphinx
force-pushed
the
adw-dialog-2nd-attempt
branch
3 times, most recently
from
97e481a to
73f2566
Compare
sungsphinx
changed the title
|
I think I know why the "stable" Flatpak CI is failing, but the unstable CI I am not quite sure about, maybe you could have a look? https://github.com/andyholmes/valent/actions/runs/8142976430/job/22274123454?pr=628#step:4:5624 |
There was a problem hiding this comment.
I would first look at those uncleared AdwDialog pointers, and if that doesn't fix it, have a look in test-window.c where test_window_dialogs is failing.
I have a suspicion it's failing on the about dialog, since all the previous tests pass. You can just comment stuff out until it passes to get that.
Oh, and the stable is failing because flatter doesn't have a beta/rc image.
You can open an MR for one if you like, but it's not necessary to if you just want to wait.
|
@andyholmes Flatpak Unstable CI finally passed 🎉, is there any other changes you would like made? |
Nope, this looks great! I will figure out branching scheme, because I don't like waiting either :) Might take a few days though, thanks for sticking with this! |
andyholmes
force-pushed
the
adw-dialog-2nd-attempt
branch
from
699a693 to
06e680d
Compare
I believe it was failing because there is no `close` action as it is not a separate window, so we just make the code run `adw_dialog_close` instead.
Co-authored-by: Andy Holmes <[email protected]>
Co-authored-by: Andy Holmes <[email protected]>
andyholmes
force-pushed
the
adw-dialog-2nd-attempt
branch
from
06e680d to
d395a84
Compare
|
Here we gooo! |
This replaces #623, hopefully the log is cleaner, as well as the weird
git rebase -ishenanigans being gone :D.