-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement setting bandwidth_limit on a servers network interface #206
base: main
Are you sure you want to change the base?
Conversation
Bumps [go.anx.io/go-anxcloud](https://github.com/anexia-it/go-anxcloud) from 0.7.3 to 0.7.4. - [Release notes](https://github.com/anexia-it/go-anxcloud/releases) - [Changelog](https://github.com/anexia-it/go-anxcloud/blob/main/CHANGELOG.md) - [Commits](anexia-it/go-anxcloud@v0.7.3...v0.7.4) --- updated-dependencies: - dependency-name: go.anx.io/go-anxcloud dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
The fact that the new autogenerated documentation is losing a lot of information in comparison to the previous iteration makes me disapprove this PR immediately. :/ Haven't checked the code itself yet, gonna do that in a sec. 👀 For now I'd prefer it if we somehow manually adjust the documentation and ensure that it matches the autogenerated version in a second PR. |
I actually didn't give much thought to the docs generator lol Just said it will replace all files and hence I didnt look deeper into why they all changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code would violate the acceptance criteria right now.
Since it is possible to change the network speed by scaling the VM via the Engine, it also should be possible via the Terraform provider.
Besides that: Thanks for the quick documentation fix! 👍
Tried to test it manually, and the creation worked fine. However, a second invocation of To reproduce it:
I got the following output:
addendum: diff --git a/Makefile b/Makefile
index 8dace30908..ee4d0bdd79 100644
--- a/Makefile
+++ b/Makefile
@@ -5,8 +5,8 @@
HOSTNAME=hashicorp.com
NAMESPACE=anexia-it
NAME=anxcloud
-BINARY=terraform-provider-${NAME}
-VERSION=0.3.1
+VERSION=0.7.0
+BINARY=terraform-provider-${NAME}_v${VERSION}
OS_ARCH=linux_amd64
GOLDFLAGS= -s -X github.com/anexia-it/terraform-provider-anxcloud.version=$(VERSION) |
Everything should be addressed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working as intended, wonderful!
If you could add one additional known limitation, which informs our users about the forced replacements for bandwidth_limit
changes, that'd be splendid.
A simple line like "Changing the speed on a network interface forces a replacement of the VM" is sufficient IMO.
Good work! 🥳
Description
After the go-anxcloud release, we now implement the
bandwidth_limit
field on the server network interface.This currently is rebased onto the dependabot branch to be able access the newly added field in go-anxcloud.
Checklist
Unreleased
section in CHANGELOG.md, if user facing changeCommunity Note