SIANXSVC-1222: Add binary file API #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 68.75% 72.13% +3.38%
==========================================
Files 4 5 +1
Lines 128 183 +55
==========================================
+ Hits 88 132 +44
- Misses 32 40 +8
- Partials 8 11 +3 ☔ View full report in Codecov by Sentry. |
nachtjasmin
requested review from
beachmachine
and removed request for
PatrickTaibel
nachtjasmin
force-pushed
the
feature/SIANXSVC-1222-add-binary-file-api
branch
from
e95fbbc
to
45ebc37
Compare
beachmachine
requested changes
Feb 26, 2024
nachtjasmin
force-pushed
the
feature/SIANXSVC-1222-add-binary-file-api
branch
from
45ebc37
to
dcdfd85
Compare
Closes SIANXSVC-1222
nachtjasmin
force-pushed
the
feature/SIANXSVC-1222-add-binary-file-api
branch
from
dcdfd85
to
40ddb00
Compare
beachmachine
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a binary API similar to the one in dotnet-e5e.
The example from the current documentation for binary files was taken and adjusted for this new API.
Closes SIANXSVC-1222