Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow theme based on system #807

Closed
wants to merge 4 commits into from
Closed

Allow theme based on system #807

wants to merge 4 commits into from

Conversation

samybtt
Copy link

@samybtt samybtt commented Dec 1, 2022

By setting the theme to "Current", the theme of the system will be used.
This solution uses darkdetect.
Should be linked to #780 and #805 .

@zwimer
Copy link
Member

zwimer commented Dec 1, 2022 •
edited
Loading

Thanks for contributing :)
This may be a duplicate of #806
Also, it looks like this PR might be lacking auto-tracking of system default; that is automatic switching of themes when users toggle dark mode. Also, as per #805 (comment) "Current" does not mean 'track System'.

@zwimer zwimer self-assigned this Dec 1, 2022
@zwimer
Copy link
Member

zwimer commented Dec 2, 2022 •
edited
Loading

Closing in favor of #806

@zwimer zwimer closed this Dec 2, 2022
@ltfish
Copy link
Member

ltfish commented Dec 3, 2022

@samybtt Thank you for submitting your first PR to angr management! Unfortunately @zwimer has already implemented this feature in another PR, as you can see. Looking forward to your next PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zwimer zwimer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samybtt @zwimer @ltfish