Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix args passing for LifterBF & optimize tests #57

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Fix args passing for LifterBF & optimize tests #57

merged 4 commits into from
Nov 21, 2023

Conversation

xxr0ss
Copy link
Contributor

@xxr0ss xxr0ss commented Nov 21, 2023

arch and addr was passed as kwargs to LifterBF, which will not be passed to Lifter through GymratLifter.__init__(self, *args).

Corresponding test code is fixed and moved to unittest.

@ltfish
Copy link
Member

ltfish commented Nov 21, 2023

Hi, can you please fix linting?

@ltfish ltfish merged commit cfcb77e into angr:master Nov 21, 2023
12 of 13 checks passed
@ltfish
Copy link
Member

ltfish commented Nov 21, 2023

Thanks!

@xxr0ss xxr0ss deleted the fix/bf branch November 22, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxr0ss @ltfish