Merge pull request #138 from angr/fix/fix-file-leak-in-qemu-tracer

Fix file leak in QEMU tracer
angr · Jul 21, 2023 · 3e0100f · 3e0100f
2 parents fafe677 + abc6ada
commit 3e0100f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/archr/analyzers/qemu_tracer.py b/archr/analyzers/qemu_tracer.py
@@ -243,9 +243,9 @@ def fire_context(
                     r.halfway_core_path = local_halfway_core_filename
 
             if target_trace_filename:
-                temp_trace_file = tempfile.mktemp(dir="/tmp", prefix="tracer-")
-                self.target.copy_file(target_trace_filename, temp_trace_file)
-                trace_fh = open(temp_trace_file, "rb")
+                temp_trace_file = tempfile.NamedTemporaryFile()
+                self.target.copy_file(target_trace_filename, temp_trace_file.name)
+                trace_fh = open(temp_trace_file.name, "rb")
 
                 # Find where qemu loaded the binary. Primarily for PIE
                 try:
@@ -303,6 +303,8 @@ def fire_context(
 
                 lastline = entry
                 bbl_trace_fh.close()
+                trace_fh.close()
+                temp_trace_file.close()
                 r.trace = QEMUBBLTrace(bbl_trace_file.name, bbl_trace_len)
 
                 if r.crashed: