unsubscribe from provided store when AngularJS app is destroyed #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AprilArcus
force-pushed
the
cleanup-subscription
branch
from
81a7bd7 to
8bf7818
Compare
AprilArcus
changed the title
AprilArcus
force-pushed
the
cleanup-subscription
branch
from
8bf7818 to
2812f6d
Compare
AprilArcus
changed the title
AprilArcus
force-pushed
the
cleanup-subscription
branch
from
2812f6d to
24617b1
Compare
AprilArcus
force-pushed
the
cleanup-subscription
branch
from
24617b1 to
fbfb2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR registers an unsubscribe callback with
$rootScope.$on('$destroy', ...)in order to prevent the memory leak identified in #247.