Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Refactor Build #29

Open
JohannesHoppe opened this issue Dec 14, 2020 · 4 comments
Open

Refactor Build #29

JohannesHoppe opened this issue Dec 14, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@JohannesHoppe
Copy link
Member

What about of having two separate package.json files?

One outside the src folder for development that will contain all the development stuff (test, build, lint, prettier, publishing, etc) and the other one inside src that would be the one that is going to be on the dist.

Personally it's little bit frustrating having the package.json inside the src folder, I always forget to step into the right folder to execute npm install.

I think with this movement will rise my development satisfaction.

Originally posted by @dianjuar in #28 (comment)

@JohannesHoppe
Copy link
Member Author

Ideas:

  1. two separate package.json files --- that's fine for me, too
  2. symbolic link to avoid 2x README --- this seems to be a bit complicated, I would vote for one README on root folder that is copied during build
  3. new idea: refactor build steps to a new file build.js, because it's super hard to read everything in one line

@dianjuar

@JohannesHoppe
Copy link
Member Author

@dianjuar I invited you as a collaborator, so that we can work together on a single branch/PR.

@dianjuar
Copy link
Collaborator

I started the first point, but I think we need to discuss some stuff about it. Every point has its implications and special discussion that it's better to take down them independently.

I think we can do the following:

  1. I think the best approach to do this is having a "master-branch" to improve the build, do individual PRs for every point to that "master-branch" to have at the end one nice PR to integrate
  2. Individual PR's to master

What do you think about this?
Do you have a different approach in mind?

@JohannesHoppe
Copy link
Member Author

option 1 sounds great! 👍

The "Collaborator" badge suits you very well, too! 😄

@JohannesHoppe JohannesHoppe added the enhancement New feature or request label Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants