-
Notifications
You must be signed in to change notification settings - Fork 30
build: create a separate tsconfig file for build #28
Conversation
"build": "rimraf dist && json2ts deploy/schema.json > deploy/schema.d.ts && tsc && copyfiles README.md builders.json collection.json ng-add-schema.json package.json ngx-deploy-starter deploy/schema.json dist", | ||
"prebuild": "rimraf dist && json2ts deploy/schema.json > deploy/schema.d.ts", | ||
"build": "tsc -p tsconfig.build.json", | ||
"postbuild": "copyfiles README.md builders.json collection.json ng-add-schema.json package.json ngx-deploy-starter deploy/schema.json dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, too!
This is a good point! |
Additionally I already thought about cleaning up the final |
And you have probably realised that npx-deploy-starter is a little bit more complicated than angular-cli-ghpages, because there are two README files. What to you think about merging them into one single file in the root? |
What about of having two separate One outside the Personally it's little bit frustrating having the package.json inside the I think with this movement will rise my development satisfaction. |
For this I do a little trick, I only have one Readme file, with all the instructions and documentation and create a symbolic link ( I feel OK, with this trick, does the job. I don't know how can I make it different. Maybe two separate Readme? |
I see a lot of potential here, let's move to a separate issue: |
I've seen that is a common practice between typescript projects to have separate tsconfig files, Angular and Nest do that.
Also, I've been discovering some improvements using this configuration on my fork:
The build is independent for the test
Currently, if there is a typo on the test, the build fails due to a compilation error.
Very inconvenient when you are making some experiments and want to try them.
The tests are not being compiled and added to the dist
On the final build, there is no need to put the test, they are useless there. This makes the compilation time faster (0.02 sec faster on my machine 🤓) and the final library lighter.