Fix disabling form controls via reactive forms; reset no longer marks as dirty #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 28, 2024 13:56
hakla
changed the title
hakla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to disable the slider by disabling or enabling a form control through reactive forms (see #223). When changing the enabled state, the slider will appear to be disabled, but it actually isn't.
This pull request fixes that (fixes #223).
I've also added a fix so that the slider no longer emits changes to angular when they come from angular, i.e. when the value is updated by calling something like
control.reset(0), the slider no longer calls the reactive forms callbacks for 'changed' and 'touched'. Previously, these would cause the controls to become dirty and touched again when the controls were reset (fixes #255).