fix(material/tabs): tab nav bar animation not working when navigating forwards #30313
+5
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
… forwards Fixes a regression introduced in angular#30121. It looks like we were depending on the incorrect internal state to animate correctly. These changes fix the issue by removing a call that was redundant in the first place. Fixes angular#30303.
crisbeto
force-pushed
the
30303/nav-bar-animation
branch
from
cbfad6f to
38086cc
Compare
wagnermaciel
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #30121. It looks like we were depending on the incorrect internal state to animate correctly.
These changes fix the issue by removing a call that was redundant in the first place.
Fixes #30303.