This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(panel): allow transform to be animated on an offset panel #11389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a panel had a position with an offset (e.g.
$mdPanel.newPanelPosition().center()
), the positioning would break anytransform
animations on the panel. This was due to the fact thatmdPanel
uses inlinetransform
styles to do the offsetting. These changes introduce a wrapper around the panel (.md-panel-inner-wrapper
), which will handle all of the positioning, allowing for any animations to be applied to the.md-panel
itself.Relates to #9641.
Fixes #9905.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
What is the new behavior?
Does this PR introduce a breaking change?
Other information